| Message ID | 20200721175326.8004-1-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 21 Jul 2020 at 18:54, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > The following changes since commit 90218a9a393c7925f330e7dcc08658e2a01d3bd4: > > Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-07= > -21' into staging (2020-07-21 10:24:38 +0100) > > are available in the Git repository at: > > https://gitlab.com/philmd/qemu.git tags/fw_cfg-20200721 > > for you to fetch changes up to 077195187b47d83418e5fb521c89d7881fab3049: > > hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value (2020= > -07-21 16:47:54 +0200) > > ---------------------------------------------------------------- > fw_cfg patches > > Fixes the DEADCODE issue reported by Coverity (CID 1430396). > > CI jobs result: > . https://gitlab.com/philmd/qemu/-/pipelines/169086301 > > ---------------------------------------------------------------- > > Philippe Mathieu-Daud=C3=A9 (2): Something in your cover-letter creation is not handling UTF-8 right :-) > hw/nvram/fw_cfg: Simplify fw_cfg_add_from_generator() error > propagation > hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM
On 7/23/20 12:43 PM, Peter Maydell wrote: > On Tue, 21 Jul 2020 at 18:54, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >> >> The following changes since commit 90218a9a393c7925f330e7dcc08658e2a01d3bd4: >> >> Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-07= >> -21' into staging (2020-07-21 10:24:38 +0100) >> >> are available in the Git repository at: >> >> https://gitlab.com/philmd/qemu.git tags/fw_cfg-20200721 >> >> for you to fetch changes up to 077195187b47d83418e5fb521c89d7881fab3049: >> >> hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value (2020= >> -07-21 16:47:54 +0200) >> >> ---------------------------------------------------------------- >> fw_cfg patches >> >> Fixes the DEADCODE issue reported by Coverity (CID 1430396). >> >> CI jobs result: >> . https://gitlab.com/philmd/qemu/-/pipelines/169086301 >> >> ---------------------------------------------------------------- >> >> Philippe Mathieu-Daud=C3=A9 (2): > > Something in your cover-letter creation is not handling UTF-8 right :-) Yes, this is a known git-publish issue: https://github.com/stefanha/git-publish/issues/88 It only happens with the cover, it doesn't affect the patches, so it is considered a very low priority issue :) > >> hw/nvram/fw_cfg: Simplify fw_cfg_add_from_generator() error >> propagation >> hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value > > > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 > for any user-visible changes. Thanks (no user-visible changes in these patches). Phil.
The following changes since commit 90218a9a393c7925f330e7dcc08658e2a01d3bd4: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-07= -21' into staging (2020-07-21 10:24:38 +0100) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/fw_cfg-20200721 for you to fetch changes up to 077195187b47d83418e5fb521c89d7881fab3049: hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value (2020= -07-21 16:47:54 +0200) ---------------------------------------------------------------- fw_cfg patches Fixes the DEADCODE issue reported by Coverity (CID 1430396). CI jobs result: . https://gitlab.com/philmd/qemu/-/pipelines/169086301 ---------------------------------------------------------------- Philippe Mathieu-Daud=C3=A9 (2): hw/nvram/fw_cfg: Simplify fw_cfg_add_from_generator() error propagation hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value include/hw/nvram/fw_cfg.h | 8 ++++++-- hw/nvram/fw_cfg.c | 13 +++++++------ softmmu/vl.c | 6 +----- 3 files changed, 14 insertions(+), 13 deletions(-) --=20 2.21.3