From patchwork Wed Jul 22 09:57:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 11678059 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1143913B1 for ; Wed, 22 Jul 2020 10:00:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCD0C2065E for ; Wed, 22 Jul 2020 10:00:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gdQv7S+K"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YBz2YWmq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCD0C2065E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sfqYtJAl3ZjhfTiJy1x0AuieSx25O6+DdiuWm9O/HuQ=; b=gdQv7S+Kxk5mv4nYkCj/NSM4m ulOjAu69EfzfhfESVWLCv21ISdqXswk1mno3vCvWzHah3KuM9H/jLbn5TLKoUt8AdOdtUpc7MiIhK Z6o8zciwvxMYlo81ByphuF4x/xAk7ZGJwVAQEYMY4ZE1tBsqomHkZOJGkW8a/ye10sFIWra5eMd8L 2B4jvyVIruCHvGDACafoOtdkRqTmOmKMDJeRTRF1Oa9D6uSbpvDCksgtcbX4wXH+nY4x47Gg0E7hh K4ZPkelH7Cj2+QrKD9X950OB9L/X5338PGJnKOVT+KTjEhRSxN4umCeIz3/tpAx8c93PxeVJXed+I dglK4Wymg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyBWK-00086R-12; Wed, 22 Jul 2020 09:58:40 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyBVr-0007wq-LD for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 09:58:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595411891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRlrJElqpWKXVzsQk+UKiqZzRm2Ymiua6dk47+4yd3E=; b=YBz2YWmqQkTwBU8Z1V3zo6V8mr8nnBlhip1kzec3hUeRlHL1OGHruoXtbfokmZ9nSYZs6T 575vs9VD1PF7K+Wu8LYumidweOvvJj9D0/bRN1uVE3bHmo4ddjwhH2WxOZy5OxUR9pvBiB sOHHsdBFfclcLL7x0x85FWtrRumENts= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-Uci_MSFuOKmaENqXP1bGmg-1; Wed, 22 Jul 2020 05:58:09 -0400 X-MC-Unique: Uci_MSFuOKmaENqXP1bGmg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 086A818C63C0; Wed, 22 Jul 2020 09:58:08 +0000 (UTC) Received: from localhost.localdomain.com (vpn2-54-170.bne.redhat.com [10.64.54.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36C9A5D9CA; Wed, 22 Jul 2020 09:58:06 +0000 (UTC) From: Gavin Shan To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 07/17] drivers/firmware/sdei: Remove Drop redundant error message in sdei_probe() Date: Wed, 22 Jul 2020 19:57:30 +1000 Message-Id: <20200722095740.28560-8-gshan@redhat.com> In-Reply-To: <20200722095740.28560-1-gshan@redhat.com> References: <20200722095740.28560-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_055811_950640_BD82716B X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [207.211.31.120 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [207.211.31.120 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, will@kernel.org, james.morse@arm.com, shan.gavin@gmail.com, catalin.marinas@arm.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This removes the redundant error message in sdei_probe() because the case can be identified from the errno in next error message. Signed-off-by: Gavin Shan --- v2: Remove changes to reorder variables --- drivers/firmware/arm_sdei.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c index 240c06ae7bfe..03b1179da9b4 100644 --- a/drivers/firmware/arm_sdei.c +++ b/drivers/firmware/arm_sdei.c @@ -982,8 +982,6 @@ static int sdei_probe(struct platform_device *pdev) return 0; err = sdei_api_get_version(&ver); - if (err == -EOPNOTSUPP) - pr_err("advertised but not implemented in platform firmware\n"); if (err) { pr_err("Failed to get SDEI version: %d\n", err); sdei_mark_interface_broken();