| Message ID | 1595493126-21611-1-git-send-email-wendell.lin@mediatek.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/1] clk: Export clk_register_composite | expand |
Hi Matthias and all, Gentle ping on this patch. Thanks Wendell Lin On Thu, 2020-07-23 at 16:32 +0800, Wendell Lin wrote: > clk_register_composite() will be used in mediatek's > clock kernel module, so export it to GPL modules. > > Signed-off-by: Wendell Lin <wendell.lin@mediatek.com> > --- > drivers/clk/clk-composite.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c > index 7376f57..7c609c2 100644 > --- a/drivers/clk/clk-composite.c > +++ b/drivers/clk/clk-composite.c > @@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name, > return ERR_CAST(hw); > return hw->clk; > } > +EXPORT_SYMBOL_GPL(clk_register_composite); > > struct clk *clk_register_composite_pdata(struct device *dev, const char *name, > const struct clk_parent_data *parent_data,
On Fri, 2021-06-04 at 09:25 +0100, Lee Jones wrote: > On Fri, 04 Jun 2021, Lee Jones wrote: > > > On Thu, 03 Jun 2021, Stephen Boyd wrote: > > > > > Quoting Lee Jones (2021-05-20 09:07:42) > > > > On Mon, 10 Aug 2020 at 10:36, Wendell Lin <wendell.lin@mediatek.com> wrote: > > > > > > > > Hi Matthias and all, > > > > > > > > Gentle ping on this patch. > > > > > > > > > > > > What about a not-so-gentle ping on this patch? Grrrr... :) > > > > > > > > FYI, this is still required by more than one source. > > > > > > > > Please help get this out of all of the vendor trees please. > > > > > > > > > > Is there an in-kernel user? > > > > How can there be? It's not exported yet. :) > > > > However there shouldn't be any barriers for vendors represented in > > Mainline to build their drivers as modules if they so wish. If/when > > they do, this will need to be exported. > > Wendell Lin, is this what you wish to do with the in-kernel MediaTek > driver? > This is because Mediatek clock driver would be built as kernel module, so clk_register_composite() used should be exported, then we could use it. Please refer: [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support https://lkml.org/lkml/2020/7/1/124 +EXPORT_SYMBOL(mtk_clk_register_composites); clk_register_composite() is used by Mediatek clk kernel module. From export symbol: mtk_clk_register_composites.
On Fri, 04 Jun 2021, Wendell Lin wrote: > On Fri, 2021-06-04 at 09:25 +0100, Lee Jones wrote: > > On Fri, 04 Jun 2021, Lee Jones wrote: > > > > > On Thu, 03 Jun 2021, Stephen Boyd wrote: > > > > > > > Quoting Lee Jones (2021-05-20 09:07:42) > > > > > On Mon, 10 Aug 2020 at 10:36, Wendell Lin <wendell.lin@mediatek.com> wrote: > > > > > > > > > > Hi Matthias and all, > > > > > > > > > > Gentle ping on this patch. > > > > > > > > > > > > > > > What about a not-so-gentle ping on this patch? Grrrr... :) > > > > > > > > > > FYI, this is still required by more than one source. > > > > > > > > > > Please help get this out of all of the vendor trees please. > > > > > > > > > > > > > Is there an in-kernel user? > > > > > > How can there be? It's not exported yet. :) > > > > > > However there shouldn't be any barriers for vendors represented in > > > Mainline to build their drivers as modules if they so wish. If/when > > > they do, this will need to be exported. > > > > Wendell Lin, is this what you wish to do with the in-kernel MediaTek > > driver? > > > This is because Mediatek clock driver would be built as kernel module, > so clk_register_composite() used should be exported, then we could use > it. > > Please refer: > [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support > https://lkml.org/lkml/2020/7/1/124 > +EXPORT_SYMBOL(mtk_clk_register_composites); > > clk_register_composite() is used by Mediatek clk kernel module. > From export symbol: mtk_clk_register_composites. Perfect. Thanks for the clarification. Anything else you need from us Stephen?
Quoting Lee Jones (2021-06-04 06:23:35) > On Fri, 04 Jun 2021, Wendell Lin wrote: > > > On Fri, 2021-06-04 at 09:25 +0100, Lee Jones wrote: > > > On Fri, 04 Jun 2021, Lee Jones wrote: > > > > > > > On Thu, 03 Jun 2021, Stephen Boyd wrote: > > > > > > > > > Quoting Lee Jones (2021-05-20 09:07:42) > > > > > > On Mon, 10 Aug 2020 at 10:36, Wendell Lin <wendell.lin@mediatek.com> wrote: > > > > > > > > > > > > Hi Matthias and all, > > > > > > > > > > > > Gentle ping on this patch. > > > > > > > > > > > > > > > > > > What about a not-so-gentle ping on this patch? Grrrr... :) > > > > > > > > > > > > FYI, this is still required by more than one source. > > > > > > > > > > > > Please help get this out of all of the vendor trees please. > > > > > > > > > > > > > > > > Is there an in-kernel user? > > > > > > > > How can there be? It's not exported yet. :) > > > > > > > > However there shouldn't be any barriers for vendors represented in > > > > Mainline to build their drivers as modules if they so wish. If/when > > > > they do, this will need to be exported. > > > > > > Wendell Lin, is this what you wish to do with the in-kernel MediaTek > > > driver? > > > > > This is because Mediatek clock driver would be built as kernel module, > > so clk_register_composite() used should be exported, then we could use > > it. > > > > Please refer: > > [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support > > https://lkml.org/lkml/2020/7/1/124 > > +EXPORT_SYMBOL(mtk_clk_register_composites); > > > > clk_register_composite() is used by Mediatek clk kernel module. > > From export symbol: mtk_clk_register_composites. > > Perfect. Thanks for the clarification. > > Anything else you need from us Stephen? > Is the mediatek driver compilable as a module? Last time I checked it wasn't a module. I want an upstream modular driver that uses the symbol. Otherwise we're exporting symbols when it doesn't need to be.
diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c index 7376f57..7c609c2 100644 --- a/drivers/clk/clk-composite.c +++ b/drivers/clk/clk-composite.c @@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name, return ERR_CAST(hw); return hw->clk; } +EXPORT_SYMBOL_GPL(clk_register_composite); struct clk *clk_register_composite_pdata(struct device *dev, const char *name, const struct clk_parent_data *parent_data,
clk_register_composite() will be used in mediatek's clock kernel module, so export it to GPL modules. Signed-off-by: Wendell Lin <wendell.lin@mediatek.com> --- drivers/clk/clk-composite.c | 1 + 1 file changed, 1 insertion(+)