diff mbox series

drm/i915/selftests: Downgrade severity of CS/SRM frequency scaling

Message ID 20200723140747.27839-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show
Series drm/i915/selftests: Downgrade severity of CS/SRM frequency scaling | expand

Commit Message

Chris Wilson July 23, 2020, 2:07 p.m. UTC
Gracefully skip over the failures in the frequency scaling for the
moment, the results are under review.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Sundaresan, Sujaritha" <sujaritha.sundaresan@intel.com>
Cc: "Ewins, Jon" <jon.ewins@intel.com>
---
 drivers/gpu/drm/i915/gt/selftest_rps.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sundaresan, Sujaritha July 23, 2020, 3:28 p.m. UTC | #1
On 7/23/2020 6:07 PM, Chris Wilson wrote:
> Gracefully skip over the failures in the frequency scaling for the
> moment, the results are under review.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Sundaresan, Sujaritha" <sujaritha.sundaresan@intel.com>
> Cc: "Ewins, Jon" <jon.ewins@intel.com>
> ---
>   drivers/gpu/drm/i915/gt/selftest_rps.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> index 8624f5d2a1f3..b50ed20c427c 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> @@ -700,7 +700,7 @@ int live_rps_frequency_cs(void *arg)
>   				f = act; /* may skip ahead [pcu granularity] */
>   			}
>   
> -			err = -EINVAL;
> +			err = -EINTR;
>   		}
>   
>   err_vma:
> @@ -841,7 +841,7 @@ int live_rps_frequency_srm(void *arg)
>   				f = act; /* may skip ahead [pcu granularity] */
>   			}
>   
> -			err = -EINVAL;
> +			err = -EINTR;
>   		}
>   
>   err_vma:

The BAT failure looks to be unrelated.

Hopefully we can get a little more clarity in the future as to why the

CS does not scale once we are sure that there are no HW or PCU issues.

Reviewed-by : Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
index 8624f5d2a1f3..b50ed20c427c 100644
--- a/drivers/gpu/drm/i915/gt/selftest_rps.c
+++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
@@ -700,7 +700,7 @@  int live_rps_frequency_cs(void *arg)
 				f = act; /* may skip ahead [pcu granularity] */
 			}
 
-			err = -EINVAL;
+			err = -EINTR;
 		}
 
 err_vma:
@@ -841,7 +841,7 @@  int live_rps_frequency_srm(void *arg)
 				f = act; /* may skip ahead [pcu granularity] */
 			}
 
-			err = -EINVAL;
+			err = -EINTR;
 		}
 
 err_vma: