| Message ID | 20200723134902.26290-1-yung-chuan.liao@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soundwire: master: enable pm runtime | expand |
On Thu, Jul 23, 2020 at 09:49:02PM +0800, Bard Liao wrote:
> We should enable pm runtime.
Because why?
Please read the documentation about how to write good changelog
comments...
greg k-h
> -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Friday, July 24, 2020 4:32 PM > To: Bard Liao <yung-chuan.liao@linux.intel.com> > Cc: alsa-devel@alsa-project.org; vkoul@kernel.org; vinod.koul@linaro.org; > linux-kernel@vger.kernel.org; tiwai@suse.de; broonie@kernel.org; > jank@cadence.com; srinivas.kandagatla@linaro.org; > rander.wang@linux.intel.com; ranjani.sridharan@linux.intel.com; > hui.wang@canonical.com; pierre-louis.bossart@linux.intel.com; Kale, Sanyog > R <sanyog.r.kale@intel.com>; Lin, Mengdong <mengdong.lin@intel.com>; > Liao, Bard <bard.liao@intel.com> > Subject: Re: [PATCH] soundwire: master: enable pm runtime > > On Thu, Jul 23, 2020 at 09:49:02PM +0800, Bard Liao wrote: > > We should enable pm runtime. > > Because why? The hierarchy of soundwire devices is platform device -> M device -> S device. A S device is physically attached on the platform device. So the platform device should be resumed when a S device is resumed. As the bridge of platform device and S device, we have to implement runtime pm on M driver. We have set runtime pm ops in M driver already, but still need to enable runtime pm. > > Please read the documentation about how to write good changelog > comments... Sure. I will update the changelog in next version. Thanks for the advice. > > greg k-h
diff --git a/drivers/soundwire/master.c b/drivers/soundwire/master.c index 5f0b2189defe..3488bb824e84 100644 --- a/drivers/soundwire/master.c +++ b/drivers/soundwire/master.c @@ -154,6 +154,7 @@ int sdw_master_device_add(struct sdw_bus *bus, struct device *parent, bus->dev = &md->dev; bus->md = md; + pm_runtime_enable(&bus->md->dev); device_register_err: return ret; } @@ -166,6 +167,7 @@ int sdw_master_device_add(struct sdw_bus *bus, struct device *parent, */ int sdw_master_device_del(struct sdw_bus *bus) { + pm_runtime_disable(&bus->md->dev); device_unregister(bus->dev); return 0;
We should enable pm runtime. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> --- drivers/soundwire/master.c | 2 ++ 1 file changed, 2 insertions(+)