btrfs/162: Stop using device mount option
diff mbox series

Message ID 20200724131250.3377-1-nborisov@suse.com
State New
Headers show
Series
  • btrfs/162: Stop using device mount option
Related show

Commit Message

Nikolay Borisov July 24, 2020, 1:12 p.m. UTC
btrfs is clever enough to figure out which devices constitute the sprout
fs even without specifying them explicitly with -o device. Additionally,
explicitly settings the devices via -o device reduces coverage of the
test since it didn't detect breakage a local change introduced. Without
-o device instead this breakage was detected.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 tests/btrfs/162 | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Anand Jain July 30, 2020, 2:57 a.m. UTC | #1
On 24/7/20 9:12 pm, Nikolay Borisov wrote:
> btrfs is clever enough to figure out which devices constitute the sprout
> fs even without specifying them explicitly with -o device.

   holds good only in this test case.

> Additionally,
> explicitly settings the devices via -o device reduces coverage of the
> test since it didn't detect breakage a local change introduced.

  We relay on unmount not freeing up the btrfs_device.

> Without
> -o device instead this breakage was detected.

  That's like testing two things in one test case. I am ok.

> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

  Reviewed-by: Anand.Jain@oracle.com

Patch
diff mbox series

diff --git a/tests/btrfs/162 b/tests/btrfs/162
index 7f119be057b7..ff3c50b1be54 100755
--- a/tests/btrfs/162
+++ b/tests/btrfs/162
@@ -69,11 +69,10 @@  create_sprout_seed()
 
 create_next_sprout()
 {
-	run_check _mount -o device=$dev_seed $dev_sprout_seed $SCRATCH_MNT
+	run_check _mount $dev_sprout_seed $SCRATCH_MNT
 	_run_btrfs_util_prog device add -f $dev_sprout $SCRATCH_MNT
 	_scratch_unmount
-	run_check _mount -o device=$dev_seed,device=$dev_sprout_seed \
-		$dev_sprout $SCRATCH_MNT
+	run_check _mount $dev_sprout $SCRATCH_MNT
 	echo -- sprout --
 	od -x $SCRATCH_MNT/foobar
 }