| Message ID | 20200728122743.78489-1-frank-w@public-files.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] net: ethernet: mtk_eth_soc: fix mtu warning | expand |
On Tue, Jul 28, 2020 at 02:27:43PM +0200, Frank Wunderlich wrote: > From: Landen Chao <landen.chao@mediatek.com> > > in recent Kernel-Versions there are warnings about incorrect MTU-Size > like these: > > eth0: mtu greater than device maximum > mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead > > Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports") > Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU") > Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack") > Signed-off-by: René van Dorst <opensource@vdorst.com> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Tue, 28 Jul 2020 14:27:43 +0200 Frank Wunderlich wrote: > From: Landen Chao <landen.chao@mediatek.com> Hi gents, if the patch is from Landen we need his sign-off on it. > in recent Kernel-Versions there are warnings about incorrect MTU-Size > like these: > > eth0: mtu greater than device maximum > mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead > > Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports") > Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU") > Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack") > Signed-off-by: René van Dorst <opensource@vdorst.com> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
On Tue, Jul 28, 2020 at 02:27:43PM +0200, Frank Wunderlich wrote: > From: Landen Chao <landen.chao@mediatek.com> > > in recent Kernel-Versions there are warnings about incorrect MTU-Size > like these: Can the above also be fixed for incorrect capitalisation and improper hyphernation please? Thanks. > > eth0: mtu greater than device maximum > mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead > > Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports") > Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU") > Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack") > Signed-off-by: René van Dorst <opensource@vdorst.com> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 85735d32ecb0..a1c45b39a230 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -2891,6 +2891,8 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np) > eth->netdev[id]->irq = eth->irq[0]; > eth->netdev[id]->dev.of_node = np; > > + eth->netdev[id]->max_mtu = MTK_MAX_RX_LENGTH - MTK_RX_ETH_HLEN; > + > return 0; > > free_netdev: > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Frank, If you send next version of patch, you can help to add the Signed-off line. Thanks. Signed-off-by: Landen Chao <landen.chao@mediatek.com> On Tue, 2020-07-28 at 23:53 +0800, Jakub Kicinski wrote: > On Tue, 28 Jul 2020 14:27:43 +0200 Frank Wunderlich wrote: > > From: Landen Chao <landen.chao@mediatek.com> > > Hi gents, > > if the patch is from Landen we need his sign-off on it. > > > in recent Kernel-Versions there are warnings about incorrect MTU-Size > > like these: > > > > eth0: mtu greater than device maximum > > mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead > > > > Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports") > > Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU") > > Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack") > > Signed-off-by: René van Dorst <opensource@vdorst.com> > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> >
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 85735d32ecb0..a1c45b39a230 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -2891,6 +2891,8 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np) eth->netdev[id]->irq = eth->irq[0]; eth->netdev[id]->dev.of_node = np; + eth->netdev[id]->max_mtu = MTK_MAX_RX_LENGTH - MTK_RX_ETH_HLEN; + return 0; free_netdev: