| Message ID | 20200729073902.1704-1-b18007@students.iitmandi.ac.in (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] Staging : media : atomisp : fixed a brace coding sytle issue | expand |
On Wed, Jul 29, 2020 at 01:09:02PM +0530, Ankit Baluni wrote: > Removed braces for a 'if' condition as it contain only single line & > there is no need for braces for such case according to coding style > rules. > > Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in> > > --- > Changes in v2: > -Added more description about the patch. > -Added space before the symobol '<' in 'From' > and 'Signed-off-by' line. > Changes in v3: > -Removed space before ':' in subject line. No you did not :(
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c index 8ea65bef35d2..28b96b66f4f3 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c @@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp, case ATOMISP_CAMERA_PORT_SECONDARY: return MIPI_PORT1_ID; case ATOMISP_CAMERA_PORT_TERTIARY: - if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) { + if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) return MIPI_PORT1_ID + 1; - } /* fall through */ default: dev_err(isp->dev, "unsupported port: %d\n", port);
Removed braces for a 'if' condition as it contain only single line & there is no need for braces for such case according to coding style rules. Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in> --- Changes in v2: -Added more description about the patch. -Added space before the symobol '<' in 'From' and 'Signed-off-by' line. Changes in v3: -Removed space before ':' in subject line. drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)