diff mbox series

[2/7] ARM: s3c64xx: Include header to fix -Wmissing-prototypes

Message ID 20200729160942.28867-3-krzk@kernel.org (mailing list archive)
State Superseded
Headers show
Series ARM: samsung: Cleanup of various S3C bits | expand

Commit Message

Krzysztof Kozlowski July 29, 2020, 4:09 p.m. UTC
Include the spi-s3c64xx.h header to fix W=1 build warning:

    arch/arm/mach-s3c64xx/setup-spi.c:11:5: warning:
        no previous prototype for 's3c64xx_spi0_cfg_gpio' [-Wmissing-prototypes]
       11 | int s3c64xx_spi0_cfg_gpio(void)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/mach-s3c64xx/setup-spi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Tomasz Figa July 29, 2020, 5:46 p.m. UTC | #1
2020年7月29日(水) 18:11 Krzysztof Kozlowski <krzk@kernel.org>:
>
> Include the spi-s3c64xx.h header to fix W=1 build warning:
>
>     arch/arm/mach-s3c64xx/setup-spi.c:11:5: warning:
>         no previous prototype for 's3c64xx_spi0_cfg_gpio' [-Wmissing-prototypes]
>        11 | int s3c64xx_spi0_cfg_gpio(void)
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm/mach-s3c64xx/setup-spi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c64xx/setup-spi.c b/arch/arm/mach-s3c64xx/setup-spi.c
> index 39dfae1f46e7..03c9d296bb0f 100644
> --- a/arch/arm/mach-s3c64xx/setup-spi.c
> +++ b/arch/arm/mach-s3c64xx/setup-spi.c
> @@ -4,6 +4,7 @@
>  //             http://www.samsung.com/
>
>  #include <linux/gpio.h>
> +#include <linux/platform_data/spi-s3c64xx.h>
>  #include <plat/gpio-cfg.h>
>  #include <mach/gpio-samsung.h>
>
> --
> 2.17.1
>

Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz
diff mbox series

Patch

diff --git a/arch/arm/mach-s3c64xx/setup-spi.c b/arch/arm/mach-s3c64xx/setup-spi.c
index 39dfae1f46e7..03c9d296bb0f 100644
--- a/arch/arm/mach-s3c64xx/setup-spi.c
+++ b/arch/arm/mach-s3c64xx/setup-spi.c
@@ -4,6 +4,7 @@ 
 //		http://www.samsung.com/
 
 #include <linux/gpio.h>
+#include <linux/platform_data/spi-s3c64xx.h>
 #include <plat/gpio-cfg.h>
 #include <mach/gpio-samsung.h>