| Message ID | 20200730073939.33704-1-wanghai38@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 20e6421344b5bc2f97b8e2db47b6994368417904 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [net] wl1251: fix always return 0 error | expand |
Wang Hai <wanghai38@huawei.com> wrote: > wl1251_event_ps_report() should not always return 0 because > wl1251_ps_set_mode() may fail. Change it to return 'ret'. > > Fixes: f7ad1eed4d4b ("wl1251: retry power save entry") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wang Hai <wanghai38@huawei.com> Patch applied to wireless-drivers-next.git, thanks. 20e6421344b5 wl1251: fix always return 0 error
diff --git a/drivers/net/wireless/ti/wl1251/event.c b/drivers/net/wireless/ti/wl1251/event.c index 850864dbafa1..e6d426edab56 100644 --- a/drivers/net/wireless/ti/wl1251/event.c +++ b/drivers/net/wireless/ti/wl1251/event.c @@ -70,7 +70,7 @@ static int wl1251_event_ps_report(struct wl1251 *wl, break; } - return 0; + return ret; } static void wl1251_event_mbox_dump(struct event_mailbox *mbox)
wl1251_event_ps_report() should not always return 0 because wl1251_ps_set_mode() may fail. Change it to return 'ret'. Fixes: f7ad1eed4d4b ("wl1251: retry power save entry") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wang Hai <wanghai38@huawei.com> --- drivers/net/wireless/ti/wl1251/event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)