| Message ID | BN6PR04MB0660B938349CA15DE7BCC5BBA3710@BN6PR04MB0660.namprd04.prod.outlook.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2,01/11] media: exynos4-is: Remove static driver data for S5PV210 FIMC variants | expand |
On 31.07.2020 01:01, Jonathan Bakker wrote: > The parallel port nodes should be numbered 1 and 2, not 0 and 1 > for A and B respectively. The driver has always implemented 1 > and 2 and the in-tree Goni DTS uses 1 as port A as well. Update > the documentation to match this behaviour. > > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Thanks for all those improvements, whole series looks good to me.
On Thu, 30 Jul 2020 16:01:14 -0700, Jonathan Bakker wrote: > The parallel port nodes should be numbered 1 and 2, not 0 and 1 > for A and B respectively. The driver has always implemented 1 > and 2 and the in-tree Goni DTS uses 1 as port A as well. Update > the documentation to match this behaviour. > > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> > --- > Changes from v1: > - New patch replacing patch modifying driver to match documentation > --- > Documentation/devicetree/bindings/media/samsung-fimc.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt index f91b9dc80eb3..20447529c985 100644 --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt @@ -95,7 +95,7 @@ Optional properties: This node should contain child 'port' nodes specifying active parallel video input ports. It includes camera A and camera B inputs. 'reg' property in the -port nodes specifies data input - 0, 1 indicates input A, B respectively. +port nodes specifies data input - 1, 2 indicates input A, B respectively. Optional properties @@ -172,8 +172,8 @@ Example: /* parallel camera ports */ parallel-ports { /* camera A input */ - port@0 { - reg = <0>; + port@1 { + reg = <1>; fimc0_ep: endpoint { remote-endpoint = <&s5k6aa_ep>; bus-width = <8>;
The parallel port nodes should be numbered 1 and 2, not 0 and 1 for A and B respectively. The driver has always implemented 1 and 2 and the in-tree Goni DTS uses 1 as port A as well. Update the documentation to match this behaviour. Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> --- Changes from v1: - New patch replacing patch modifying driver to match documentation --- Documentation/devicetree/bindings/media/samsung-fimc.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)