| Message ID | 20200802110636.1018743-18-sam@ravnborg.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | backlight: add init macros and accessors | expand |
Hi Sam,
I love your patch! Yet something to improve:
[auto build test ERROR on backlight/for-backlight-next]
[also build test ERROR on next-20200731]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master drm/drm-next v5.8-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sam-Ravnborg/backlight-add-init-macros-and-accessors/20200802-190940
base: for-backlight-next
config: arm-randconfig-r016-20200802 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/tilcdc/tilcdc_panel.c: In function 'panel_encoder_dpms':
>> drivers/gpu/drm/tilcdc/tilcdc_panel.c:50:6: error: 'pmode' undeclared (first use in this function); did you mean 'mode'?
50 | if (pmode == DRM_MODE_DPMS_O)
| ^~~~~
| mode
drivers/gpu/drm/tilcdc/tilcdc_panel.c:50:6: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/tilcdc/tilcdc_panel.c:50:15: error: 'DRM_MODE_DPMS_O' undeclared (first use in this function); did you mean 'DRM_MODE_DPMS_ON'?
50 | if (pmode == DRM_MODE_DPMS_O)
| ^~~~~~~~~~~~~~~
| DRM_MODE_DPMS_ON
vim +50 drivers/gpu/drm/tilcdc/tilcdc_panel.c
43
44 static void panel_encoder_dpms(struct drm_encoder *encoder, int mode)
45 {
46 struct panel_encoder *panel_encoder = to_panel_encoder(encoder);
47 struct backlight_device *backlight = panel_encoder->mod->backlight;
48 struct gpio_desc *gpio = panel_encoder->mod->enable_gpio;
49
> 50 if (pmode == DRM_MODE_DPMS_O)
51 backlight_set_power_on(backlight);
52 else
53 backlight_set_power_off(backlight);
54
55 backlight_update_status(backlight);
56
57 if (gpio)
58 gpiod_set_value_cansleep(gpio,
59 mode == DRM_MODE_DPMS_ON ? 1 : 0);
60 }
61
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c index 12823d60c4e8..54824999720b 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c @@ -47,11 +47,12 @@ static void panel_encoder_dpms(struct drm_encoder *encoder, int mode) struct backlight_device *backlight = panel_encoder->mod->backlight; struct gpio_desc *gpio = panel_encoder->mod->enable_gpio; - if (backlight) { - backlight->props.power = mode == DRM_MODE_DPMS_ON ? - FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN; - backlight_update_status(backlight); - } + if (pmode == DRM_MODE_DPMS_O) + backlight_set_power_on(backlight); + else + backlight_set_power_off(backlight); + + backlight_update_status(backlight); if (gpio) gpiod_set_value_cansleep(gpio,
Avoid using direct access to backlight_properties by introducing set methods for power. Dropped extra check as both set methods and backlight_update_status() both accepts a NULL backlight device. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Rob Clark <robdclark@gmail.com> Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Cc: Jyri Sarha <jsarha@ti.com> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)