| Message ID | 20200802173059.122595-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | rcar-vin: Remove redundant compatible values | expand |
Hi Niklas, On Sun, Aug 2, 2020 at 8:05 PM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > The compatible value 'renesas,rcar-gen2-vin' have always been mandatory > for all Gen2 platforms. Remove device redundant values. That's not true: the DTS files for R-Car H2, M2-W, and E2 lacked the family-specific compatible values during the first few years of their existence. However, given we dropped support for the old CPG and MSTP DT bindings, it's reasonable to assume all working systems have them. > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> With a slight update of the description: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c index 7440c8965d27e64f..aad8eef2ac9f641b 100644 --- a/drivers/media/platform/rcar-vin/rcar-core.c +++ b/drivers/media/platform/rcar-vin/rcar-core.c @@ -1228,22 +1228,6 @@ static const struct of_device_id rvin_of_id_table[] = { .compatible = "renesas,vin-r8a7779", .data = &rcar_info_h1, }, - { - .compatible = "renesas,vin-r8a7790", - .data = &rcar_info_gen2, - }, - { - .compatible = "renesas,vin-r8a7791", - .data = &rcar_info_gen2, - }, - { - .compatible = "renesas,vin-r8a7793", - .data = &rcar_info_gen2, - }, - { - .compatible = "renesas,vin-r8a7794", - .data = &rcar_info_gen2, - }, { .compatible = "renesas,rcar-gen2-vin", .data = &rcar_info_gen2,
The compatible value 'renesas,rcar-gen2-vin' have always been mandatory for all Gen2 platforms. Remove device redundant values. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar-core.c | 16 ---------------- 1 file changed, 16 deletions(-) --- Hi, After the recent bindings conversion to YAML which makes it abundantly clear that the generic 'renesas,rcar-gen2-vin' compatibility value are mandatory (which is always have been) remove values that are not needed to reduce size.