diff mbox series

iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER

Message ID 20200803083001.6689-1-michael@walle.cc (mailing list archive)
State New, archived
Headers show
Series iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER | expand

Commit Message

Michael Walle Aug. 3, 2020, 8:30 a.m. UTC
The kernel fails to compile due to undefined reference to
devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not
enabled. The original patch [1] had this dependency. But somehow it
didn't make it into the kernel tree. Re-add it.

[1] https://lore.kernel.org/lkml/20200623233011.2319035-3-heiko@sntech.de/

Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
Signed-off-by: Michael Walle <michael@walle.cc>
---
 drivers/iio/adc/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Heiko Stuebner Aug. 3, 2020, 11:59 a.m. UTC | #1
Am Montag, 3. August 2020, 10:30:01 CEST schrieb Michael Walle:
> The kernel fails to compile due to undefined reference to
> devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not
> enabled. The original patch [1] had this dependency. But somehow it
> didn't make it into the kernel tree. Re-add it.
> 
> [1] https://lore.kernel.org/lkml/20200623233011.2319035-3-heiko@sntech.de/
> 
> Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

> ---
>  drivers/iio/adc/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 66d9cc073157..d94dc800b842 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -865,6 +865,8 @@ config ROCKCHIP_SARADC
>  	tristate "Rockchip SARADC driver"
>  	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
>  	depends on RESET_CONTROLLER
> +	select IIO_BUFFER
> +	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Say yes here to build support for the SARADC found in SoCs from
>  	  Rockchip.
>
Jonathan Cameron Aug. 9, 2020, 11:52 a.m. UTC | #2
On Mon, 03 Aug 2020 13:59:12 +0200
Heiko Stuebner <heiko.stuebner@theobroma-systems.com> wrote:

> Am Montag, 3. August 2020, 10:30:01 CEST schrieb Michael Walle:
> > The kernel fails to compile due to undefined reference to
> > devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not
> > enabled. The original patch [1] had this dependency. But somehow it
> > didn't make it into the kernel tree. Re-add it.
> > 
> > [1] https://lore.kernel.org/lkml/20200623233011.2319035-3-heiko@sntech.de/
> > 
> > Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
> > Signed-off-by: Michael Walle <michael@walle.cc>  
> 
> Reviewed-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan
> 
> > ---
> >  drivers/iio/adc/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index 66d9cc073157..d94dc800b842 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -865,6 +865,8 @@ config ROCKCHIP_SARADC
> >  	tristate "Rockchip SARADC driver"
> >  	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
> >  	depends on RESET_CONTROLLER
> > +	select IIO_BUFFER
> > +	select IIO_TRIGGERED_BUFFER
> >  	help
> >  	  Say yes here to build support for the SARADC found in SoCs from
> >  	  Rockchip.
> >   
> 
> 
> 
>
diff mbox series

Patch

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 66d9cc073157..d94dc800b842 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -865,6 +865,8 @@  config ROCKCHIP_SARADC
 	tristate "Rockchip SARADC driver"
 	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
 	depends on RESET_CONTROLLER
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for the SARADC found in SoCs from
 	  Rockchip.