leds: s3c24xx: Remove unused machine header include
diff mbox series

Message ID 20200803091936.24984-1-krzk@kernel.org
State Not Applicable
Headers show
Series
  • leds: s3c24xx: Remove unused machine header include
Related show

Commit Message

Krzysztof Kozlowski Aug. 3, 2020, 9:19 a.m. UTC
The driver includes machine header for GPIO registers but actually does
not use them.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/leds/leds-s3c24xx.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Pavel Machek Aug. 5, 2020, 9:57 p.m. UTC | #1
On Mon 2020-08-03 11:19:36, Krzysztof Kozlowski wrote:
> The driver includes machine header for GPIO registers but actually does
> not use them.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Thanks, applied.
Krzysztof Kozlowski Aug. 20, 2020, 4:08 p.m. UTC | #2
On Wed, Aug 05, 2020 at 11:57:30PM +0200, Pavel Machek wrote:
> On Mon 2020-08-03 11:19:36, Krzysztof Kozlowski wrote:
> > The driver includes machine header for GPIO registers but actually does
> > not use them.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Thanks, applied.

Hi Pavel,

I am confused because I had impression this will go into v5.9-rc1 but
it's not there.  My further S3C cleanup depends on it [1] and now
applying of the patches stuck in the middle.

I could take the patch through samsung-soc along with the rest of the
series or pull from stable tag (but tag with only that patch...).

Best regards,
Krzysztof
Krzysztof Kozlowski Aug. 20, 2020, 4:10 p.m. UTC | #3
On Thu, Aug 20, 2020 at 06:08:16PM +0200, Krzysztof Kozlowski wrote:
> On Wed, Aug 05, 2020 at 11:57:30PM +0200, Pavel Machek wrote:
> > On Mon 2020-08-03 11:19:36, Krzysztof Kozlowski wrote:
> > > The driver includes machine header for GPIO registers but actually does
> > > not use them.
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > 
> > Thanks, applied.
> 
> Hi Pavel,
> 
> I am confused because I had impression this will go into v5.9-rc1 but
> it's not there.  My further S3C cleanup depends on it [1] and now
> applying of the patches stuck in the middle.
> 
> I could take the patch through samsung-soc along with the rest of the
> series or pull from stable tag (but tag with only that patch...).

... and the missing link:
[1] https://marc.info/?l=dri-devel&m=159793916332137&w=2

Best regards,
Krzysztof
Pavel Machek Aug. 20, 2020, 9:51 p.m. UTC | #4
On Thu 2020-08-20 18:08:16, Krzysztof Kozlowski wrote:
> On Wed, Aug 05, 2020 at 11:57:30PM +0200, Pavel Machek wrote:
> > On Mon 2020-08-03 11:19:36, Krzysztof Kozlowski wrote:
> > > The driver includes machine header for GPIO registers but actually does
> > > not use them.
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > 
> > Thanks, applied.
> 
> Hi Pavel,
> 
> I am confused because I had impression this will go into v5.9-rc1 but
> it's not there.  My further S3C cleanup depends on it [1] and now
> applying of the patches stuck in the middle.

It was too late for -rc1 at that moment. It is on my for-next branch
now.

									Pavel

Patch
diff mbox series

diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
index 9b5e67664ba3..3c0c7aa63b8c 100644
--- a/drivers/leds/leds-s3c24xx.c
+++ b/drivers/leds/leds-s3c24xx.c
@@ -16,8 +16,6 @@ 
 #include <linux/module.h>
 #include <linux/platform_data/leds-s3c24xx.h>
 
-#include <mach/regs-gpio.h>
-
 /* our context */
 
 struct s3c24xx_gpio_led {