diff mbox series

[for-5.2,v2,8/9] pc-bios/s390-ccw/main: Remove superfluous call to enable_subchannel()

Message ID 20200806105349.632-9-thuth@redhat.com (mailing list archive)
State New, archived
Headers show
Series Continue booting in case the first device is not bootable | expand

Commit Message

Thomas Huth Aug. 6, 2020, 10:53 a.m. UTC
enable_subchannel() is already done during is_dev_possibly_bootable()
(which is called from find_boot_device() -> find_subch()), so there
is no need to do this again in the main() function.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 pc-bios/s390-ccw/main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Cornelia Huck Aug. 6, 2020, 11:21 a.m. UTC | #1
On Thu,  6 Aug 2020 12:53:48 +0200
Thomas Huth <thuth@redhat.com> wrote:

> enable_subchannel() is already done during is_dev_possibly_bootable()
> (which is called from find_boot_device() -> find_subch()), so there
> is no need to do this again in the main() function.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  pc-bios/s390-ccw/main.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>
diff mbox series

Patch

diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c
index fc17e6ab83..43c792cf95 100644
--- a/pc-bios/s390-ccw/main.c
+++ b/pc-bios/s390-ccw/main.c
@@ -280,7 +280,6 @@  int main(void)
     boot_setup();
     if (have_iplb) {
         find_boot_device();
-        enable_subchannel(blk_schid);
         ipl_boot_device();
     } else {
         probe_boot_device();