diff mbox series

[PATCH-for-5.2,2/4] hw/char/serial: Remove old DEBUG_SERIAL commented code

Message ID 20200806130340.17316-3-f4bug@amsat.org (mailing list archive)
State New, archived
Headers show
Series hw/char/serial: Use the Clock API to feed the UART reference clock | expand

Commit Message

Philippe Mathieu-Daudé Aug. 6, 2020, 1:03 p.m. UTC 
All useful DPRINTF() calls have been converted to trace
events.  Remove a pointless one in the IOEventHandler,
and drop the DEBUG_SERIAL ifdef'ry.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/char/serial.c | 11 -----------
 1 file changed, 11 deletions(-)

Comments

Richard Henderson Aug. 12, 2020, 5:42 p.m. UTC | #1 
On 8/6/20 6:03 AM, Philippe Mathieu-Daudé wrote:
> All useful DPRINTF() calls have been converted to trace
> events.  Remove a pointless one in the IOEventHandler,
> and drop the DEBUG_SERIAL ifdef'ry.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/char/serial.c | 11 -----------
>  1 file changed, 11 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~
diff mbox series

Patch

diff --git a/hw/char/serial.c b/hw/char/serial.c
index 3e903d5fad..758a3aa49b 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -36,8 +36,6 @@ 
 #include "trace.h"
 #include "hw/qdev-properties.h"
 
-//#define DEBUG_SERIAL
-
 #define UART_LCR_DLAB	0x80	/* Divisor latch access bit */
 
 #define UART_IER_MSI	0x08	/* Enable Modem status interrupt */
@@ -102,14 +100,6 @@ 
 
 #define MAX_XMIT_RETRY      4
 
-#ifdef DEBUG_SERIAL
-#define DPRINTF(fmt, ...) \
-do { fprintf(stderr, "serial: " fmt , ## __VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-do {} while (0)
-#endif
-
 static void serial_receive1(void *opaque, const uint8_t *buf, int size);
 static void serial_xmit(SerialState *s);
 
@@ -636,7 +626,6 @@  static void serial_receive1(void *opaque, const uint8_t *buf, int size)
 static void serial_event(void *opaque, QEMUChrEvent event)
 {
     SerialState *s = opaque;
-    DPRINTF("event %x\n", event);
     if (event == CHR_EVENT_BREAK)
         serial_receive_break(s);
 }