[077/163] mm: memcg/slab: remove redundant check in memcg_accumulate_slabinfo()

Commit Message

Andrew Morton Aug. 7, 2020, 6:21 a.m. UTC

From: Roman Gushchin <[e-mail]>
Subject: mm: memcg/slab: remove redundant check in memcg_accumulate_slabinfo()

memcg_accumulate_slabinfo() is never called with a non-root kmem_cache as
a first argument, so the is_root_cache(s) check is redundant and can be
removed without any functional change.

Link: http://lkml.kernel.org/r/[e-mail]
Signed-off-by: Roman Gushchin <[e-mail]>
Reviewed-by: Vlastimil Babka <[e-mail]>
Reviewed-by: Shakeel Butt <[e-mail]>
Cc: Christoph Lameter <[e-mail]>
Cc: Johannes Weiner <[e-mail]>
Cc: Michal Hocko <[e-mail]>
Cc: Tejun Heo <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/slab_common.c |    3 ---
 1 file changed, 3 deletions(-)

Patch

--- a/mm/slab_common.c~mm-memcg-slab-remove-redundant-check-in-memcg_accumulate_slabinfo
+++ a/mm/slab_common.c
@@ -1104,9 +1104,6 @@  memcg_accumulate_slabinfo(struct kmem_ca
 	struct kmem_cache *c;
 	struct slabinfo sinfo;
 
-	if (!is_root_cache(s))
-		return;
-
 	c = memcg_cache(s);
 	if (c) {
 		memset(&sinfo, 0, sizeof(sinfo));