| Message ID | 20200809172243.15192-1-steve@sk2.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 876bb6314743c92d4ae4011a493758974bc4c974 |
| Headers | show |
| Series | [v2] ARM: s3c64xx: use simple i2c probe function | expand |
On Sun, Aug 09, 2020 at 07:22:43PM +0200, Stephen Kitt wrote: > The i2c probe functions here don't use the id information provided in > their second argument, so the single-parameter i2c probe function > ("probe_new") can be used instead. > > This avoids scanning the identifier tables during probes. > > Signed-off-by: Stephen Kitt <steve@sk2.org> This is useful, helps deprecating the old probe method: Acked-by: Wolfram Sang <wsa@kernel.org>
Hi, On 09/08/20 19:22, Stephen Kitt wrote: > The i2c probe functions here don't use the id information provided in > their second argument, so the single-parameter i2c probe function > ("probe_new") can be used instead. > > This avoids scanning the identifier tables during probes. > > Signed-off-by: Stephen Kitt <steve@sk2.org> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
On Sun, Aug 09, 2020 at 07:22:43PM +0200, Stephen Kitt wrote: > The i2c probe functions here don't use the id information provided in > their second argument, so the single-parameter i2c probe function > ("probe_new") can be used instead. > > This avoids scanning the identifier tables during probes. > > Signed-off-by: Stephen Kitt <steve@sk2.org> > --- > Changes since v1: > - split into per-sub-architecture patches. > > arch/arm/mach-s3c64xx/mach-crag6410-module.c | 5 ++--- Thanks, applied. Best regards, Krzysztof
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-s3c64xx/mach-crag6410-module.c index 34f1baa10c54..43b587e79d21 100644 --- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c +++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c @@ -378,8 +378,7 @@ static const struct { .i2c_devs = wm2200_i2c, .num_i2c_devs = ARRAY_SIZE(wm2200_i2c) }, }; -static int wlf_gf_module_probe(struct i2c_client *i2c, - const struct i2c_device_id *i2c_id) +static int wlf_gf_module_probe(struct i2c_client *i2c) { int ret, i, j, id, rev; @@ -432,7 +431,7 @@ static struct i2c_driver wlf_gf_module_driver = { .driver = { .name = "wlf-gf-module" }, - .probe = wlf_gf_module_probe, + .probe_new = wlf_gf_module_probe, .id_table = wlf_gf_module_id, };
The i2c probe functions here don't use the id information provided in their second argument, so the single-parameter i2c probe function ("probe_new") can be used instead. This avoids scanning the identifier tables during probes. Signed-off-by: Stephen Kitt <steve@sk2.org> --- Changes since v1: - split into per-sub-architecture patches. arch/arm/mach-s3c64xx/mach-crag6410-module.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) base-commit: bcf876870b95592b52519ed4aafcf9d95999bc9c