diff mbox series

[v2,3/3] ARM: dts: iwg20d-q7-common: Fix touch controller probe failure

Message ID 20200810152219.6254-4-biju.das.jz@bp.renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series Add optional regulator support for LVDS codec. | expand

Commit Message

Biju Das Aug. 10, 2020, 3:22 p.m. UTC
As per the iWave RZ/G1M schematic, the signal LVDS_PPEN controls supply
voltage for touch panel, LVDS receiver and RGB LCD panel. Add regulator
for these device nodes and remove powerdown-gpios property from
lvds-receiver node as it results in touch controller driver probe failure.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 v1->v2 : Add regulator in touch panel, LVDS receiver and RGB LCD panel device nodes
 v1 : https://patchwork.kernel.org/patch/11705819/
---
 arch/arm/boot/dts/iwg20d-q7-common.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Biju Das Aug. 10, 2020, 5:34 p.m. UTC | #1
> Subject: [PATCH v2 3/3] ARM: dts: iwg20d-q7-common: Fix touch controller
> probe failure
>
> As per the iWave RZ/G1M schematic, the signal LVDS_PPEN controls supply
> voltage for touch panel, LVDS receiver and RGB LCD panel. Add regulator for
> these device nodes and remove powerdown-gpios property from lvds-
> receiver node as it results in touch controller driver probe failure.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  v1->v2 : Add regulator in touch panel, LVDS receiver and RGB LCD panel
> device nodes
>  v1 : https://patchwork.kernel.org/patch/11705819/
> ---
>  arch/arm/boot/dts/iwg20d-q7-common.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> index 4c8b9a6b0125..056f93119d8a 100644
> --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> @@ -57,6 +57,7 @@
>
>  lvds-receiver {
>  compatible = "ti,ds90cf384a", "lvds-decoder";
> +vcc-supply = <&vcc_3v3_tft1>;

Sorry, will sent V3  for  this patch, since it is  missing removal of powerdown-gpios property.

>  ports {
>  #address-cells = <1>;
> @@ -80,6 +81,7 @@
>  panel {
>  compatible = "edt,etm0700g0dh6";
>  backlight = <&lcd_backlight>;
> +power-supply = <&vcc_3v3_tft1>;
>
>  port {
>  panel_in: endpoint {
> @@ -112,6 +114,17 @@
>  };
>  };
>
> +vcc_3v3_tft1: regulator-panel {
> +compatible = "regulator-fixed";
> +
> +regulator-name = "Panel Vcc";
> +regulator-min-microvolt = <3300000>;
> +regulator-max-microvolt = <3300000>;
> +enable-active-high;
> +startup-delay-us = <70000>;
> +gpio = <&gpio7 25 GPIO_ACTIVE_HIGH>;
> +};
> +
>  vcc_sdhi1: regulator-vcc-sdhi1 {
>  compatible = "regulator-fixed";
>
> @@ -206,6 +219,7 @@
>  reg = <0x38>;
>  interrupt-parent = <&gpio2>;
>  interrupts = <12 IRQ_TYPE_EDGE_FALLING>;
> +vcc-supply = <&vcc_3v3_tft1>;
>  };
>  };
>
> --
> 2.17.1



Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
index 4c8b9a6b0125..056f93119d8a 100644
--- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
+++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
@@ -57,6 +57,7 @@ 
 
 	lvds-receiver {
 		compatible = "ti,ds90cf384a", "lvds-decoder";
+		vcc-supply = <&vcc_3v3_tft1>;
 
 		ports {
 			#address-cells = <1>;
@@ -80,6 +81,7 @@ 
 	panel {
 		compatible = "edt,etm0700g0dh6";
 		backlight = <&lcd_backlight>;
+		power-supply = <&vcc_3v3_tft1>;
 
 		port {
 			panel_in: endpoint {
@@ -112,6 +114,17 @@ 
 		};
 	};
 
+	vcc_3v3_tft1: regulator-panel {
+		compatible = "regulator-fixed";
+
+		regulator-name = "Panel Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		enable-active-high;
+		startup-delay-us = <70000>;
+		gpio = <&gpio7 25 GPIO_ACTIVE_HIGH>;
+	};
+
 	vcc_sdhi1: regulator-vcc-sdhi1 {
 		compatible = "regulator-fixed";
 
@@ -206,6 +219,7 @@ 
 		reg = <0x38>;
 		interrupt-parent = <&gpio2>;
 		interrupts = <12 IRQ_TYPE_EDGE_FALLING>;
+		vcc-supply = <&vcc_3v3_tft1>;
 	};
 };