| Message ID | 20200810152219.6254-2-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add optional regulator support for LVDS codec. | expand |
Hi Biju, Thank you for the patch. On Mon, Aug 10, 2020 at 04:22:17PM +0100, Biju Das wrote: > Document optional vcc-supply property that may be used as VCC source. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > New patch Ref: Ref:https://patchwork.kernel.org/patch/11705819/ > --- > .../devicetree/bindings/display/bridge/lvds-codec.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > index 68951d56ebba..3248be31eceb 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > @@ -79,6 +79,9 @@ properties: > The GPIO used to control the power down line of this device. > maxItems: 1 > > + vcc-supply: > + maxItems: 1 > + > required: > - compatible > - ports
On Mon, Aug 10, 2020 at 04:22:17PM +0100, Biju Das wrote: > Document optional vcc-supply property that may be used as VCC source. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > New patch Ref: Ref:https://patchwork.kernel.org/patch/11705819/ > --- > .../devicetree/bindings/display/bridge/lvds-codec.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > index 68951d56ebba..3248be31eceb 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > @@ -79,6 +79,9 @@ properties: > The GPIO used to control the power down line of this device. > maxItems: 1 > > + vcc-supply: > + maxItems: 1 Probably should be 'power-supply' to align with the 'simple' panels. That's also to signify there's only 1 supply. Using 'vcc' would encourage adding 'vdd-supply', 'vddio-supply', etc. A second supply I'll NAK because at that point it's not a simple bridge with no configuration (it's arguably already there). Rob
Hi Rob, Thanks for the feedback. > Subject: Re: [PATCH v2 1/3] dt-bindings: display: bridge: lvds-codec: > Document vcc-supply property > > On Mon, Aug 10, 2020 at 04:22:17PM +0100, Biju Das wrote: > > Document optional vcc-supply property that may be used as VCC source. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > New patch Ref: Ref:https://patchwork.kernel.org/patch/11705819/ > > --- > > .../devicetree/bindings/display/bridge/lvds-codec.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > index 68951d56ebba..3248be31eceb 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds- > codec.yaml > > @@ -79,6 +79,9 @@ properties: > > The GPIO used to control the power down line of this device. > > maxItems: 1 > > > > + vcc-supply: > > + maxItems: 1 > > Probably should be 'power-supply' to align with the 'simple' panels. > That's also to signify there's only 1 supply. Using 'vcc' would encourage > adding 'vdd-supply', 'vddio-supply', etc. A second supply I'll NAK because at > that point it's not a simple bridge with no configuration (it's arguably already > there). Yes, I am ok with 'power-supply', since LVDS CODEC driver is generic and also to align with terminology used in generic 'simple' panels. In our case this Receiver converts LVDS signals to RGB signals and fed this signal to simple panel. On the receiver part, We need to supply power to TTL output, PLL and LVDS input. It all derived from the single power source. Laurent, Please share you opinion on this. Cheers, Biju Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
Hello, On Wed, Aug 26, 2020 at 06:58:50AM +0000, Biju Das wrote: > > Subject: Re: [PATCH v2 1/3] dt-bindings: display: bridge: lvds-codec: > > Document vcc-supply property > > > > On Mon, Aug 10, 2020 at 04:22:17PM +0100, Biju Das wrote: > > > Document optional vcc-supply property that may be used as VCC source. > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > --- > > > New patch Ref: Ref:https://patchwork.kernel.org/patch/11705819/ > > > --- > > > .../devicetree/bindings/display/bridge/lvds-codec.yaml | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > index 68951d56ebba..3248be31eceb 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > @@ -79,6 +79,9 @@ properties: > > > The GPIO used to control the power down line of this device. > > > maxItems: 1 > > > > > > + vcc-supply: > > > + maxItems: 1 > > > > Probably should be 'power-supply' to align with the 'simple' panels. > > That's also to signify there's only 1 supply. Using 'vcc' would encourage > > adding 'vdd-supply', 'vddio-supply', etc. A second supply I'll NAK because at > > that point it's not a simple bridge with no configuration (it's arguably already > > there). > > Yes, I am ok with 'power-supply', since LVDS CODEC driver is generic > and also to align with terminology used in generic 'simple' panels. > > In our case this Receiver converts LVDS signals to RGB signals and fed > this signal to simple panel. > On the receiver part, We need to supply power to TTL output, PLL and > LVDS input. It all derived from the single power source. > > Laurent, Please share you opinion on this. Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> That is, I think it's a good idea to rename it, and I agree with Rob about not adding a second supply. I've applied the modified patch to my tree, and will send a pull request this week.
Hi Rob, On Mon, Aug 24, 2020 at 05:04:58PM -0600, Rob Herring wrote: > On Mon, Aug 10, 2020 at 04:22:17PM +0100, Biju Das wrote: > > Document optional vcc-supply property that may be used as VCC source. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > New patch Ref: Ref:https://patchwork.kernel.org/patch/11705819/ > > --- > > .../devicetree/bindings/display/bridge/lvds-codec.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > index 68951d56ebba..3248be31eceb 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > @@ -79,6 +79,9 @@ properties: > > The GPIO used to control the power down line of this device. > > maxItems: 1 > > > > + vcc-supply: > > + maxItems: 1 > > Probably should be 'power-supply' to align with the 'simple' panels. > That's also to signify there's only 1 supply. Using 'vcc' would > encourage adding 'vdd-supply', 'vddio-supply', etc. A second supply I'll > NAK because at that point it's not a simple bridge with no configuration > (it's arguably already there). Fully agreed. Do I get your Ab or Rb line with s/vcc/power/ and the commit message updated to dt-bindings: display: bridge: lvds-codec: Document power-supply property Document optional power-supply property that may be used to specify the regulator powering up the device. ?
On Tue, Sep 1, 2020 at 4:27 AM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Rob, > > On Mon, Aug 24, 2020 at 05:04:58PM -0600, Rob Herring wrote: > > On Mon, Aug 10, 2020 at 04:22:17PM +0100, Biju Das wrote: > > > Document optional vcc-supply property that may be used as VCC source. > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > --- > > > New patch Ref: Ref:https://patchwork.kernel.org/patch/11705819/ > > > --- > > > .../devicetree/bindings/display/bridge/lvds-codec.yaml | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > index 68951d56ebba..3248be31eceb 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > > @@ -79,6 +79,9 @@ properties: > > > The GPIO used to control the power down line of this device. > > > maxItems: 1 > > > > > > + vcc-supply: > > > + maxItems: 1 > > > > Probably should be 'power-supply' to align with the 'simple' panels. > > That's also to signify there's only 1 supply. Using 'vcc' would > > encourage adding 'vdd-supply', 'vddio-supply', etc. A second supply I'll > > NAK because at that point it's not a simple bridge with no configuration > > (it's arguably already there). > > Fully agreed. > > Do I get your Ab or Rb line with s/vcc/power/ and the commit message > updated to > > dt-bindings: display: bridge: lvds-codec: Document power-supply property > > Document optional power-supply property that may be used to specify the > regulator powering up the device. > > ? Yes, if not too late. Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml index 68951d56ebba..3248be31eceb 100644 --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml @@ -79,6 +79,9 @@ properties: The GPIO used to control the power down line of this device. maxItems: 1 + vcc-supply: + maxItems: 1 + required: - compatible - ports
Document optional vcc-supply property that may be used as VCC source. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- New patch Ref: Ref:https://patchwork.kernel.org/patch/11705819/ --- .../devicetree/bindings/display/bridge/lvds-codec.yaml | 3 +++ 1 file changed, 3 insertions(+)