| Message ID | 1597161231-32303-5-git-send-email-yibin.gong@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | add ecspi ERR009165 for i.mx6/7 soc family | expand |
On Tue, Aug 11, 2020 at 11:53:43PM +0800, Robin Gong wrote: > Since sdma_transfer_init() will do sdma_load_context before any > sdma transfer, no need once more in sdma_config_channel(). > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > Acked-by: Vinod Koul <vkoul@kernel.org> Hi Robin, thanks for the pointer to this patch. As you suggested I've tested the two patches on my custom i.MX6DL board. Therefore please feel free to add: Tested-by: Richard Leitner <richard.leitner@skidata.com> regards;rl > --- > drivers/dma/imx-sdma.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index d305b80..5411e01e 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1137,7 +1137,6 @@ static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac) > static int sdma_config_channel(struct dma_chan *chan) > { > struct sdma_channel *sdmac = to_sdma_chan(chan); > - int ret; > > sdma_disable_channel(chan); > > @@ -1177,9 +1176,7 @@ static int sdma_config_channel(struct dma_chan *chan) > sdmac->watermark_level = 0; /* FIXME: M3_BASE_ADDRESS */ > } > > - ret = sdma_load_context(sdmac); > - > - return ret; > + return 0; > } > > static int sdma_set_channel_priority(struct sdma_channel *sdmac, > -- > 2.7.4 > >
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index d305b80..5411e01e 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1137,7 +1137,6 @@ static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac) static int sdma_config_channel(struct dma_chan *chan) { struct sdma_channel *sdmac = to_sdma_chan(chan); - int ret; sdma_disable_channel(chan); @@ -1177,9 +1176,7 @@ static int sdma_config_channel(struct dma_chan *chan) sdmac->watermark_level = 0; /* FIXME: M3_BASE_ADDRESS */ } - ret = sdma_load_context(sdmac); - - return ret; + return 0; } static int sdma_set_channel_priority(struct sdma_channel *sdmac,