| Message ID | 20200811190252.10559-2-sibis@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag | expand |
Hi, On Tue, Aug 11, 2020 at 12:03 PM Sibi Sankar <sibis@codeaurora.org> wrote: > > All the power domains exposed as part of AOSS QMP driver require to stay > powered on for suspend. They are powered on when the remote processors > boots up and powered off on remote processor crash/shutdown. Mark the > power domains with GENPD_FLAG_SUSPEND_ON to model this behavior. > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > --- > drivers/soc/qcom/qcom_aoss.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c > index ed2c687c16b31..5a5b4bf928147 100644 > --- a/drivers/soc/qcom/qcom_aoss.c > +++ b/drivers/soc/qcom/qcom_aoss.c > @@ -366,6 +366,7 @@ static int qmp_pd_add(struct qmp *qmp) > res[i].pd.name = sdm845_resources[i]; > res[i].pd.power_on = qmp_pd_power_on; > res[i].pd.power_off = qmp_pd_power_off; > + res[i].pd.flags = GENPD_FLAG_SUSPEND_ON; Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested-by: Douglas Anderson <dianders@chromium.org> This makes my patch [1] unnecessary. [1] https://lore.kernel.org/r/20200805091141.1.I86b3faaecb0d82997b599b1300f879606c71e116@changeid -Doug
diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index ed2c687c16b31..5a5b4bf928147 100644 --- a/drivers/soc/qcom/qcom_aoss.c +++ b/drivers/soc/qcom/qcom_aoss.c @@ -366,6 +366,7 @@ static int qmp_pd_add(struct qmp *qmp) res[i].pd.name = sdm845_resources[i]; res[i].pd.power_on = qmp_pd_power_on; res[i].pd.power_off = qmp_pd_power_off; + res[i].pd.flags = GENPD_FLAG_SUSPEND_ON; ret = pm_genpd_init(&res[i].pd, NULL, true); if (ret < 0) {
All the power domains exposed as part of AOSS QMP driver require to stay powered on for suspend. They are powered on when the remote processors boots up and powered off on remote processor crash/shutdown. Mark the power domains with GENPD_FLAG_SUSPEND_ON to model this behavior. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- drivers/soc/qcom/qcom_aoss.c | 1 + 1 file changed, 1 insertion(+)