[v33,6/6] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes
diff mbox series

Message ID 20200812195020.13568-7-dmurphy@ti.com
State New
Headers show
Series
  • LP50xx addition and remainder Multicolor patches
Related show

Commit Message

Dan Murphy Aug. 12, 2020, 7:50 p.m. UTC
Add the reg property to each channel node.  This update is
to accommodate the multicolor framework.  In addition to the
accommodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
CC: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
 arch/arm/boot/dts/ste-href.dtsi | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

Comments

Linus Walleij Aug. 27, 2020, 10:58 p.m. UTC | #1
On Wed, Aug 12, 2020 at 9:50 PM Dan Murphy <dmurphy@ti.com> wrote:

> Add the reg property to each channel node.  This update is
> to accommodate the multicolor framework.  In addition to the
> accommodation this allows the LEDs to be placed on any channel
> and allow designs to skip channels as opposed to requiring
> sequential order.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> CC: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Pavel Machek <pavel@ucw.cz>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

I don't knof if I should just apply these two patches or if there are
dependencies that need to go in first. I guess yes?

Yours,
Linus Walleij
Dan Murphy Aug. 28, 2020, 6:39 p.m. UTC | #2
Linus

On 8/27/20 5:58 PM, Linus Walleij wrote:
> On Wed, Aug 12, 2020 at 9:50 PM Dan Murphy <dmurphy@ti.com> wrote:
>
>> Add the reg property to each channel node.  This update is
>> to accommodate the multicolor framework.  In addition to the
>> accommodation this allows the LEDs to be placed on any channel
>> and allow designs to skip channels as opposed to requiring
>> sequential order.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> CC: Linus Walleij <linus.walleij@linaro.org>
>> Acked-by: Pavel Machek <pavel@ucw.cz>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> I don't knof if I should just apply these two patches or if there are
> dependencies that need to go in first. I guess yes?

I believe all dependencies have been met for these

Dan

> Yours,
> Linus Walleij
Linus Walleij Sept. 7, 2020, 11:50 a.m. UTC | #3
On Fri, Aug 28, 2020 at 8:39 PM Dan Murphy <dmurphy@ti.com> wrote:

> > I don't knof if I should just apply these two patches or if there are
> > dependencies that need to go in first. I guess yes?
>
> I believe all dependencies have been met for these

OK I applied this patch to the Ux500 tree!

Yours,
Linus Walleij

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/ste-href.dtsi b/arch/arm/boot/dts/ste-href.dtsi
index 33e3b0b3c53d..ff47cbf6ed3b 100644
--- a/arch/arm/boot/dts/ste-href.dtsi
+++ b/arch/arm/boot/dts/ste-href.dtsi
@@ -58,16 +58,21 @@  lp5521@33 {
 				reg = <0x33>;
 				label = "lp5521_pri";
 				clock-mode = /bits/ 8 <2>;
-				chan0 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				chan@0 {
+					reg = <0>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 					linux,default-trigger = "heartbeat";
 				};
-				chan1 {
+				chan@1 {
+					reg = <1>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 				};
-				chan2 {
+				chan@2 {
+					reg = <2>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 				};
@@ -77,15 +82,20 @@  lp5521@34 {
 				reg = <0x34>;
 				label = "lp5521_sec";
 				clock-mode = /bits/ 8 <2>;
-				chan0 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				chan@0 {
+					reg = <0>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 				};
-				chan1 {
+				chan@1 {
+					reg = <1>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 				};
-				chan2 {
+				chan@2 {
+					reg = <2>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 				};