diff mbox series

[27/41] qom: Fix G_DEFINE_AUTOPTR_CLEANUP_FUNC

Message ID 20200813222625.243136-28-ehabkost@redhat.com (mailing list archive)
State New, archived
Headers show
Series qom: Automated conversion of type checking boilerplate | expand

Commit Message

Eduardo Habkost Aug. 13, 2020, 10:26 p.m. UTC
ModuleObjName##Class was being used instead of ModuleObjName.
Fix it.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 include/qom/object.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel P. Berrangé Aug. 17, 2020, 4:04 p.m. UTC | #1
On Thu, Aug 13, 2020 at 06:26:11PM -0400, Eduardo Habkost wrote:
> ModuleObjName##Class was being used instead of ModuleObjName.
> Fix it.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  include/qom/object.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


though I'd suggest just squashing it into the original buggy
patch.

> 
> diff --git a/include/qom/object.h b/include/qom/object.h
> index be64421089..f515230f61 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -571,7 +571,7 @@ struct Object
>      typedef struct ModuleObjName ModuleObjName; \
>      typedef struct ModuleObjName##Class ModuleObjName##Class; \
>      \
> -    G_DEFINE_AUTOPTR_CLEANUP_FUNC(ModuleObjName##Class, object_unref) \
> +    G_DEFINE_AUTOPTR_CLEANUP_FUNC(ModuleObjName, object_unref) \
>      \
>      static inline G_GNUC_UNUSED ModuleObjName##Class * \
>      MODULE_OBJ_NAME##_GET_CLASS(void *obj) \
> -- 
> 2.26.2
> 

Regards,
Daniel
diff mbox series

Patch

diff --git a/include/qom/object.h b/include/qom/object.h
index be64421089..f515230f61 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -571,7 +571,7 @@  struct Object
     typedef struct ModuleObjName ModuleObjName; \
     typedef struct ModuleObjName##Class ModuleObjName##Class; \
     \
-    G_DEFINE_AUTOPTR_CLEANUP_FUNC(ModuleObjName##Class, object_unref) \
+    G_DEFINE_AUTOPTR_CLEANUP_FUNC(ModuleObjName, object_unref) \
     \
     static inline G_GNUC_UNUSED ModuleObjName##Class * \
     MODULE_OBJ_NAME##_GET_CLASS(void *obj) \