| Message ID | a020884b-fa44-e732-699f-2b79c9b7d15e@infradead.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | x86/pci: fix xen.c build error when CONFIG_ACPI is not set | expand |
Hi Konrad, ping. I am still seeing this build error. It looks like this is in your territory to merge... On 8/13/20 4:00 PM, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix build error when CONFIG_ACPI is not set/enabled: > > ../arch/x86/pci/xen.c: In function ‘pci_xen_init’: > ../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration] > acpi_noirq_set(); > > Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Cc: xen-devel@lists.xenproject.org > Cc: linux-pci@vger.kernel.org > --- > arch/x86/pci/xen.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200813.orig/arch/x86/pci/xen.c > +++ linux-next-20200813/arch/x86/pci/xen.c > @@ -26,6 +26,7 @@ > #include <asm/xen/pci.h> > #include <asm/xen/cpuid.h> > #include <asm/apic.h> > +#include <asm/acpi.h> > #include <asm/i8259.h> > > static int xen_pcifront_enable_irq(struct pci_dev *dev) > thanks.
On Wed, Aug 19, 2020 at 08:09:11PM -0700, Randy Dunlap wrote: > Hi Konrad, Hey Randy, I believe Juergen is picking this up. > > ping. > > I am still seeing this build error. It looks like this is > in your territory to merge... > > > On 8/13/20 4:00 PM, Randy Dunlap wrote: > > From: Randy Dunlap <rdunlap@infradead.org> > > > > Fix build error when CONFIG_ACPI is not set/enabled: > > > > ../arch/x86/pci/xen.c: In function ‘pci_xen_init’: > > ../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration] > > acpi_noirq_set(); > > > > Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef") > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Cc: Bjorn Helgaas <bhelgaas@google.com> > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > Cc: xen-devel@lists.xenproject.org > > Cc: linux-pci@vger.kernel.org > > --- > > arch/x86/pci/xen.c | 1 + > > 1 file changed, 1 insertion(+) > > > > --- linux-next-20200813.orig/arch/x86/pci/xen.c > > +++ linux-next-20200813/arch/x86/pci/xen.c > > @@ -26,6 +26,7 @@ > > #include <asm/xen/pci.h> > > #include <asm/xen/cpuid.h> > > #include <asm/apic.h> > > +#include <asm/acpi.h> > > #include <asm/i8259.h> > > > > static int xen_pcifront_enable_irq(struct pci_dev *dev) > > > > > thanks. > -- > ~Randy >
On 20.08.20 16:40, Konrad Rzeszutek Wilk wrote: > On Wed, Aug 19, 2020 at 08:09:11PM -0700, Randy Dunlap wrote: >> Hi Konrad, > > Hey Randy, > > I believe Juergen is picking this up. Yes, have queued it for rc2. Juergen >> >> ping. >> >> I am still seeing this build error. It looks like this is >> in your territory to merge... >> >> >> On 8/13/20 4:00 PM, Randy Dunlap wrote: >>> From: Randy Dunlap <rdunlap@infradead.org> >>> >>> Fix build error when CONFIG_ACPI is not set/enabled: >>> >>> ../arch/x86/pci/xen.c: In function ‘pci_xen_init’: >>> ../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration] >>> acpi_noirq_set(); >>> >>> Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef") >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >>> Cc: Bjorn Helgaas <bhelgaas@google.com> >>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >>> Cc: xen-devel@lists.xenproject.org >>> Cc: linux-pci@vger.kernel.org >>> --- >>> arch/x86/pci/xen.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> --- linux-next-20200813.orig/arch/x86/pci/xen.c >>> +++ linux-next-20200813/arch/x86/pci/xen.c >>> @@ -26,6 +26,7 @@ >>> #include <asm/xen/pci.h> >>> #include <asm/xen/cpuid.h> >>> #include <asm/apic.h> >>> +#include <asm/acpi.h> >>> #include <asm/i8259.h> >>> >>> static int xen_pcifront_enable_irq(struct pci_dev *dev) >>> >> >> >> thanks. >> -- >> ~Randy >> >
--- linux-next-20200813.orig/arch/x86/pci/xen.c +++ linux-next-20200813/arch/x86/pci/xen.c @@ -26,6 +26,7 @@ #include <asm/xen/pci.h> #include <asm/xen/cpuid.h> #include <asm/apic.h> +#include <asm/acpi.h> #include <asm/i8259.h> static int xen_pcifront_enable_irq(struct pci_dev *dev)