| Message ID | 20200818154633.5421-1-aford173@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] thermal: ti-soc-thermal: Enable addition power management | expand |
Hi Adam,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on omap/for-next]
[also build test WARNING on balbi-usb/testing/next linus/master v5.9-rc1 next-20200818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Adam-Ford/thermal-ti-soc-thermal-Enable-addition-power-management/20200819-000006
base: https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git for-next
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/thermal/ti-soc-thermal/ti-bandgap.c:38:12: warning: 'bandgap_omap_cpu_notifier' used but never defined
38 | static int bandgap_omap_cpu_notifier(struct notifier_block *nb,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
# https://github.com/0day-ci/linux/commit/ad9a82ecd12253bef4dfda9192916ae04b09ea6e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Adam-Ford/thermal-ti-soc-thermal-Enable-addition-power-management/20200819-000006
git checkout ad9a82ecd12253bef4dfda9192916ae04b09ea6e
vim +/bandgap_omap_cpu_notifier +38 drivers/thermal/ti-soc-thermal/ti-bandgap.c
36
37 static int ti_bandgap_force_single_read(struct ti_bandgap *bgp, int id);
> 38 static int bandgap_omap_cpu_notifier(struct notifier_block *nb,
39 unsigned long cmd, void *v);
40
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Hi Adam,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on omap/for-next]
[also build test WARNING on balbi-usb/testing/next linus/master v5.9-rc1 next-20200818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Adam-Ford/thermal-ti-soc-thermal-Enable-addition-power-management/20200819-000006
base: https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git for-next
config: riscv-randconfig-r033-20200818 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/thermal/ti-soc-thermal/ti-bandgap.c:38:12: warning: function 'bandgap_omap_cpu_notifier' has internal linkage but is not defined [-Wundefined-internal]
static int bandgap_omap_cpu_notifier(struct notifier_block *nb,
^
drivers/thermal/ti-soc-thermal/ti-bandgap.c:1019:26: note: used here
bgp->nb.notifier_call = bandgap_omap_cpu_notifier;
^
1 warning generated.
# https://github.com/0day-ci/linux/commit/ad9a82ecd12253bef4dfda9192916ae04b09ea6e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Adam-Ford/thermal-ti-soc-thermal-Enable-addition-power-management/20200819-000006
git checkout ad9a82ecd12253bef4dfda9192916ae04b09ea6e
vim +/bandgap_omap_cpu_notifier +38 drivers/thermal/ti-soc-thermal/ti-bandgap.c
36
37 static int ti_bandgap_force_single_read(struct ti_bandgap *bgp, int id);
> 38 static int bandgap_omap_cpu_notifier(struct notifier_block *nb,
39 unsigned long cmd, void *v);
40
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
* Adam Ford <aford173@gmail.com> [200818 15:46]: > @@ -1153,6 +1166,38 @@ static int ti_bandgap_suspend(struct device *dev) > return err; > } > > +static int bandgap_omap_cpu_notifier(struct notifier_block *nb, > + unsigned long cmd, void *v) > +{ > + struct ti_bandgap *bgp; > + > + bgp = container_of(nb, struct ti_bandgap, nb); > + > + spin_lock(&bgp->lock); > + switch (cmd) { > + case CPU_CLUSTER_PM_ENTER: > + if (bgp->is_suspended) > + break; > + ti_bandgap_save_ctxt(bgp); > + ti_bandgap_power(bgp, false); > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > + clk_disable(bgp->fclock); > + break; > + case CPU_CLUSTER_PM_ENTER_FAILED: > + case CPU_CLUSTER_PM_EXIT: > + if (bgp->is_suspended) > + break; > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > + clk_enable(bgp->fclock); > + ti_bandgap_power(bgp, true); > + ti_bandgap_restore_ctxt(bgp); > + break; > + } > + spin_unlock(&bgp->lock); > + > + return NOTIFY_OK; > +} Hmm to me it looks like is_suspended is not used right now? I guess you want to set it in ti_bandgap_suspend() and clear it in ti_bandgap_resume()? Otherwise looks good to me, I can't test the power consumption right now though so you may want to check it to make sure device still hits off mode during idle. Regards, Tony
On Tue, Aug 18, 2020 at 11:58 PM Tony Lindgren <tony@atomide.com> wrote: > > * Adam Ford <aford173@gmail.com> [200818 15:46]: > > @@ -1153,6 +1166,38 @@ static int ti_bandgap_suspend(struct device *dev) > > return err; > > } > > > > +static int bandgap_omap_cpu_notifier(struct notifier_block *nb, > > + unsigned long cmd, void *v) > > +{ > > + struct ti_bandgap *bgp; > > + > > + bgp = container_of(nb, struct ti_bandgap, nb); > > + > > + spin_lock(&bgp->lock); > > + switch (cmd) { > > + case CPU_CLUSTER_PM_ENTER: > > + if (bgp->is_suspended) > > + break; > > + ti_bandgap_save_ctxt(bgp); > > + ti_bandgap_power(bgp, false); > > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > > + clk_disable(bgp->fclock); > > + break; > > + case CPU_CLUSTER_PM_ENTER_FAILED: > > + case CPU_CLUSTER_PM_EXIT: > > + if (bgp->is_suspended) > > + break; > > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > > + clk_enable(bgp->fclock); > > + ti_bandgap_power(bgp, true); > > + ti_bandgap_restore_ctxt(bgp); > > + break; > > + } > > + spin_unlock(&bgp->lock); > > + > > + return NOTIFY_OK; > > +} > > Hmm to me it looks like is_suspended is not used right now? > I guess you want to set it in ti_bandgap_suspend() and clear > it in ti_bandgap_resume()? > > Otherwise looks good to me, I can't test the power consumption > right now though so you may want to check it to make sure > device still hits off mode during idle. I have a V2. Do you want me to re-post 2/2 with V2 as no change, or should I just submit this patch alone? adam > > Regards, > > Tony
* Adam Ford <aford173@gmail.com> [200819 12:21]: > On Tue, Aug 18, 2020 at 11:58 PM Tony Lindgren <tony@atomide.com> wrote: > > > > * Adam Ford <aford173@gmail.com> [200818 15:46]: > > > @@ -1153,6 +1166,38 @@ static int ti_bandgap_suspend(struct device *dev) > > > return err; > > > } > > > > > > +static int bandgap_omap_cpu_notifier(struct notifier_block *nb, > > > + unsigned long cmd, void *v) > > > +{ > > > + struct ti_bandgap *bgp; > > > + > > > + bgp = container_of(nb, struct ti_bandgap, nb); > > > + > > > + spin_lock(&bgp->lock); > > > + switch (cmd) { > > > + case CPU_CLUSTER_PM_ENTER: > > > + if (bgp->is_suspended) > > > + break; > > > + ti_bandgap_save_ctxt(bgp); > > > + ti_bandgap_power(bgp, false); > > > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > > > + clk_disable(bgp->fclock); > > > + break; > > > + case CPU_CLUSTER_PM_ENTER_FAILED: > > > + case CPU_CLUSTER_PM_EXIT: > > > + if (bgp->is_suspended) > > > + break; > > > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > > > + clk_enable(bgp->fclock); > > > + ti_bandgap_power(bgp, true); > > > + ti_bandgap_restore_ctxt(bgp); > > > + break; > > > + } > > > + spin_unlock(&bgp->lock); > > > + > > > + return NOTIFY_OK; > > > +} > > > > Hmm to me it looks like is_suspended is not used right now? > > I guess you want to set it in ti_bandgap_suspend() and clear > > it in ti_bandgap_resume()? > > > > Otherwise looks good to me, I can't test the power consumption > > right now though so you may want to check it to make sure > > device still hits off mode during idle. > > I have a V2. Do you want me to re-post 2/2 with V2 as no change, or > should I just submit this patch alone? Up to you, might make it easier for other folks to follow if the whole series is reposted. Regards, Tony
diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c index ab19ceff6e2a..923ef3abb867 100644 --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c @@ -25,10 +25,18 @@ #include <linux/of_platform.h> #include <linux/of_irq.h> #include <linux/io.h> +#include <linux/cpu_pm.h> +#include <linux/device.h> +#include <linux/pm_runtime.h> +#include <linux/pm.h> +#include <linux/of.h> +#include <linux/of_device.h> #include "ti-bandgap.h" static int ti_bandgap_force_single_read(struct ti_bandgap *bgp, int id); +static int bandgap_omap_cpu_notifier(struct notifier_block *nb, + unsigned long cmd, void *v); /*** Helper functions to access registers and their bitfields ***/ @@ -1008,6 +1016,9 @@ int ti_bandgap_probe(struct platform_device *pdev) } } + bgp->nb.notifier_call = bandgap_omap_cpu_notifier; + cpu_pm_register_notifier(&bgp->nb); + return 0; remove_last_cooling: @@ -1041,7 +1052,9 @@ int ti_bandgap_remove(struct platform_device *pdev) struct ti_bandgap *bgp = platform_get_drvdata(pdev); int i; - /* First thing is to remove sensor interfaces */ + cpu_pm_unregister_notifier(&bgp->nb); + + /* Remove sensor interfaces */ for (i = 0; i < bgp->conf->sensor_count; i++) { if (bgp->conf->sensors[i].unregister_cooling) bgp->conf->sensors[i].unregister_cooling(bgp, i); @@ -1153,6 +1166,38 @@ static int ti_bandgap_suspend(struct device *dev) return err; } +static int bandgap_omap_cpu_notifier(struct notifier_block *nb, + unsigned long cmd, void *v) +{ + struct ti_bandgap *bgp; + + bgp = container_of(nb, struct ti_bandgap, nb); + + spin_lock(&bgp->lock); + switch (cmd) { + case CPU_CLUSTER_PM_ENTER: + if (bgp->is_suspended) + break; + ti_bandgap_save_ctxt(bgp); + ti_bandgap_power(bgp, false); + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) + clk_disable(bgp->fclock); + break; + case CPU_CLUSTER_PM_ENTER_FAILED: + case CPU_CLUSTER_PM_EXIT: + if (bgp->is_suspended) + break; + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) + clk_enable(bgp->fclock); + ti_bandgap_power(bgp, true); + ti_bandgap_restore_ctxt(bgp); + break; + } + spin_unlock(&bgp->lock); + + return NOTIFY_OK; +} + static int ti_bandgap_resume(struct device *dev) { struct ti_bandgap *bgp = dev_get_drvdata(dev); diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.h b/drivers/thermal/ti-soc-thermal/ti-bandgap.h index fce4657e9486..ed0ea4b17b25 100644 --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.h +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.h @@ -12,6 +12,10 @@ #include <linux/spinlock.h> #include <linux/types.h> #include <linux/err.h> +#include <linux/cpu_pm.h> +#include <linux/device.h> +#include <linux/pm_runtime.h> +#include <linux/pm.h> struct gpio_desc; @@ -203,6 +207,8 @@ struct ti_bandgap { int irq; struct gpio_desc *tshut_gpiod; u32 clk_rate; + struct notifier_block nb; + unsigned int is_suspended:1; }; /**
The bandgap sensor can be idled when the processor is too, but it isn't currently being done, so the power consumption of OMAP3 boards can elevated if the bangap sensor is enabled. This patch attempts to use some additional power management to idle the clock to the bandgap when not needed. Signed-off-by: Adam Ford <aford173@gmail.com>