diff mbox series

ath9k_htc: Do not select MAC80211_LEDS by default

Message ID 20200820120444.8809-1-krzk@kernel.org (mailing list archive)
State Accepted
Commit 197f466e93f54f640cab42918a348f2c9b881ce4
Delegated to: Kalle Valo
Headers show
Series ath9k_htc: Do not select MAC80211_LEDS by default | expand

Commit Message

Krzysztof Kozlowski Aug. 20, 2020, 12:04 p.m. UTC
The ath9k_htc driver hides all LEDs related code behind
CONFIG_MAC80211_LEDS ifdefs so it does not really require the
MAC80211_LEDS.  The code builds and works just fine.  Convert the
"select" into "imply" to allow disabling LED trigger when not needed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/net/wireless/ath/ath9k/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Kalle Valo Aug. 27, 2020, 10:17 a.m. UTC | #1
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> The ath9k_htc driver hides all LEDs related code behind
> CONFIG_MAC80211_LEDS ifdefs so it does not really require the
> MAC80211_LEDS.  The code builds and works just fine.  Convert the
> "select" into "imply" to allow disabling LED trigger when not needed.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

197f466e93f5 ath9k_htc: Do not select MAC80211_LEDS by default
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig
index d5e9af2dddd8..5effb3886631 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -177,10 +177,10 @@  config ATH9K_HTC
 	tristate "Atheros HTC based wireless cards support"
 	depends on USB && MAC80211
 	select ATH9K_HW
-	select MAC80211_LEDS
-	select LEDS_CLASS
-	select NEW_LEDS
 	select ATH9K_COMMON
+	imply NEW_LEDS
+	imply LEDS_CLASS
+	imply MAC80211_LEDS
 	help
 	  Support for Atheros HTC based cards.
 	  Chipsets supported: AR9271