| Message ID | 20200826035321.18620-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] irqchip/ti-sci-intr: Fix unsigned comparison to zero | expand |
On 26/08/20 9:23 am, YueHaibing wrote: > ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq > should be int type. > > Fixes: a5b659bd4bc7 ("irqchip/ti-sci-intr: Add support for INTR being a parent to INTR") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Thanks for the patch. Acked-by: Lokesh Vutla <lokeshvutla@ti.com> Thanks and regards, Lokesh > --- > drivers/irqchip/irq-ti-sci-intr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c > index cbc1758228d9..85a72b56177c 100644 > --- a/drivers/irqchip/irq-ti-sci-intr.c > +++ b/drivers/irqchip/irq-ti-sci-intr.c > @@ -137,8 +137,8 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain, > struct ti_sci_intr_irq_domain *intr = domain->host_data; > struct device_node *parent_node; > struct irq_fwspec fwspec; > - u16 out_irq, p_hwirq; > - int err = 0; > + int p_hwirq, err = 0; > + u16 out_irq; > > out_irq = ti_sci_get_free_resource(intr->out_irqs); > if (out_irq == TI_SCI_RESOURCE_NULL) >
On Wed, 26 Aug 2020 11:53:21 +0800, YueHaibing wrote: > ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq > should be int type. Applied to irq/irqchip-fixes-5.9, thanks! [1/1] irqchip/ti-sci-intr: Fix unsigned comparison to zero commit: 8ddf1905a904ca86d71ca1c435e4b0b2a0b70df8 Cheers, M.
diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c index cbc1758228d9..85a72b56177c 100644 --- a/drivers/irqchip/irq-ti-sci-intr.c +++ b/drivers/irqchip/irq-ti-sci-intr.c @@ -137,8 +137,8 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain, struct ti_sci_intr_irq_domain *intr = domain->host_data; struct device_node *parent_node; struct irq_fwspec fwspec; - u16 out_irq, p_hwirq; - int err = 0; + int p_hwirq, err = 0; + u16 out_irq; out_irq = ti_sci_get_free_resource(intr->out_irqs); if (out_irq == TI_SCI_RESOURCE_NULL)
ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq should be int type. Fixes: a5b659bd4bc7 ("irqchip/ti-sci-intr: Add support for INTR being a parent to INTR") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/irqchip/irq-ti-sci-intr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)