| Message ID | 20200831082917.17117-7-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: Add Engicam PX30.Core | expand |
Hi Jagan, A dtsi file with only an include and no changes isn't useful. Are you planning to add something to it? Else combine in single dts file for now. Same for px30-engicam-edimm2.2.dtsi On 8/31/20 10:29 AM, Jagan Teki wrote: > Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose > carrier board with capacitive touch interface. > > Genaral features: > - TFT 10.1" industrial, 1280x800 LVDS display > - Ethernet 10/100 > - Wifi/BT > - USB Type A/OTG > - Audio Out > - CAN > - LVDS panel connector > > SOM's like PX30.Core needs to mount on top of this Carrier board > for creating complete PX30.Core C.TOUCH 2.0 board. > > Add support for it. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > --- > Changes for v3: > - add Amarula Solutions copyright > Changes for v2: > - none > > arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi > > diff --git a/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi b/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi > new file mode 100644 > index 000000000000..58425b1e559f > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi > @@ -0,0 +1,8 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2020 Engicam srl > + * Copyright (c) 2020 Amarula Solutions > + * Copyright (c) 2020 Amarula Solutions(India) > + */ > + > +#include "px30-engicam-common.dtsi" >
Hi Johan, On Mon, Aug 31, 2020 at 3:38 PM Johan Jonker <jbx6244@gmail.com> wrote: > > Hi Jagan, > > A dtsi file with only an include and no changes isn't useful. > Are you planning to add something to it? Yes, some WiFi/BT bits (with LVDS if OF used), but the idea of having separate dtsi is as per the Engicam's hardware topology. C.TOUCH2.0 is a Carrier board like EDIMM2.2 and each as its own purpose and possible to use or update as per customer needs. Maintaining separate dtsi files for a carrier board will easy for customers to use the same SOM and create their own carrier hardware. This was the customers can just add their own custom carrier and reuse existing topoply in Mainline. Hope you understand, the structure of these dtsi files. Jagan.
diff --git a/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi b/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi new file mode 100644 index 000000000000..58425b1e559f --- /dev/null +++ b/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi @@ -0,0 +1,8 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2020 Engicam srl + * Copyright (c) 2020 Amarula Solutions + * Copyright (c) 2020 Amarula Solutions(India) + */ + +#include "px30-engicam-common.dtsi"