| Message ID | 20200907082600.454-3-t-kristo@ti.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: ti: minor fixes and add sha2 instance for dra7 | expand |
Quoting Tero Kristo (2020-09-07 01:25:59) > Fix a memory leak induced by not calling clk_put after doing of_clk_get. > > Reported-by: Dan Murphy <dmurphy@ti.com> > Signed-off-by: Tero Kristo <t-kristo@ti.com> > --- Applied to clk-next
diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c index ee56306f79d5..700b7f44f671 100644 --- a/drivers/clk/ti/clockdomain.c +++ b/drivers/clk/ti/clockdomain.c @@ -148,10 +148,12 @@ static void __init of_ti_clockdomain_setup(struct device_node *node) if (!omap2_clk_is_hw_omap(clk_hw)) { pr_warn("can't setup clkdm for basic clk %s\n", __clk_get_name(clk)); + clk_put(clk); continue; } to_clk_hw_omap(clk_hw)->clkdm_name = clkdm_name; omap2_init_clk_clkdm(clk_hw); + clk_put(clk); } }
Fix a memory leak induced by not calling clk_put after doing of_clk_get. Reported-by: Dan Murphy <dmurphy@ti.com> Signed-off-by: Tero Kristo <t-kristo@ti.com> --- drivers/clk/ti/clockdomain.c | 2 ++ 1 file changed, 2 insertions(+)