| Message ID | 20200915035632.2227052-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/panel: samsung: make vint_table static | expand |
Hi Jason, Thank you for the patch. On Tue, Sep 15, 2020 at 11:56:32AM +0800, Jason Yan wrote: > This eliminates the following sparse warning: > > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c:217:15: warning: symbol > 'vint_table' was not declared. Should it be static? The commit message should mention that it also make the table const. I'd write "drm/panel: samsung: Make vint_table static const" in the subject line, and add here "While at it, make the table const as it is never modified." With those changes, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> > --- > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > index 1d1c79a18613..0ab1b7ec84cd 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > @@ -214,7 +214,7 @@ static const u8 gamma_tbl[S6E3HA2_NUM_GAMMA_STEPS][S6E3HA2_GAMMA_CMD_CNT] = { > 0x00, 0x00 } > }; > > -unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = { > +static const unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = { > 0x18, 0x19, 0x1a, 0x1b, 0x1c, > 0x1d, 0x1e, 0x1f, 0x20, 0x21 > };
diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c index 1d1c79a18613..0ab1b7ec84cd 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c @@ -214,7 +214,7 @@ static const u8 gamma_tbl[S6E3HA2_NUM_GAMMA_STEPS][S6E3HA2_GAMMA_CMD_CNT] = { 0x00, 0x00 } }; -unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = { +static const unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = { 0x18, 0x19, 0x1a, 0x1b, 0x1c, 0x1d, 0x1e, 0x1f, 0x20, 0x21 };
This eliminates the following sparse warning: drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c:217:15: warning: symbol 'vint_table' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)