| Message ID | 1600191369-28040-2-git-send-email-gene.chen.richtek@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: adc: mt6360: Add ADC driver for MT6360 | expand |
On Wed, 16 Sep 2020 01:36:07 +0800 Gene Chen <gene.chen.richtek@gmail.com> wrote: > From: Gene Chen <gene_chen@richtek.com> > > This change adds the binding doc for the MT6360 ADC. > > Signed-off-by: Gene Chen <gene_chen@richtek.com> Hi Gene A few things inline I missed before. Ideally this wants a device-tree ack which it isn't likely to get without cc'ing the binding Maintainers. I've added Rob and the list. Thanks, Jonathan > --- > .../bindings/iio/adc/mediatek,mt6360.yaml | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml > new file mode 100644 > index 0000000..2fa2fe7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/mediatek,mt6360.yaml# I think this should probably match the compatible as should the file name. (sorry missed this on previous review!) > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT6360 and similar ADCs > + > +maintainers: > + - Gene Chen <gene_chen@richtek.com> > + > +description: | > + Family of simple ADCs with i2c interface and internal references. > + > +properties: > + compatible: > + const: mediatek,mt6360-adc > + > + "#io-channel-cells": > + const: 1 > + > +required: > + - compatible > + - "#io-channel-cells" As it's fresh in my mind from forgetting it myself, can we add additionalProperties: false ? > + > +examples: > + - | > + adc { > + compatible = "mediatek,mt6360-adc"; > + #io-channel-cells = <1>; > + }; > +...
diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml new file mode 100644 index 0000000..2fa2fe7 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml @@ -0,0 +1,32 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/mediatek,mt6360.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT6360 and similar ADCs + +maintainers: + - Gene Chen <gene_chen@richtek.com> + +description: | + Family of simple ADCs with i2c interface and internal references. + +properties: + compatible: + const: mediatek,mt6360-adc + + "#io-channel-cells": + const: 1 + +required: + - compatible + - "#io-channel-cells" + +examples: + - | + adc { + compatible = "mediatek,mt6360-adc"; + #io-channel-cells = <1>; + }; +...