diff mbox series

[-next] mm/madvise: Remove set but not used variable 'zone'

Message ID 20200917071757.1915501-1-liushixin2@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] mm/madvise: Remove set but not used variable 'zone' | expand

Commit Message

Liu Shixin Sept. 17, 2020, 7:17 a.m. UTC
Fixes gcc '-Wunused-but-set-variable' warning:

mm/madvise.c: In function 'madvise_inject_error':
mm/madvise.c:882:15: warning: unused variable 'zone' [-Wunused-variable]

After 4b63fdbe2b25 ("mm: remove the now-unnecessary mmget_still_valid()
hack"), variable 'zone' is never used. Remove it to avoid build warning.

Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
 mm/madvise.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Oscar Salvador Sept. 17, 2020, 7:53 a.m. UTC | #1
On Thu, Sep 17, 2020 at 03:17:57PM +0800, Liu Shixin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> mm/madvise.c: In function 'madvise_inject_error':
> mm/madvise.c:882:15: warning: unused variable 'zone' [-Wunused-variable]
> 
> After 4b63fdbe2b25 ("mm: remove the now-unnecessary mmget_still_valid()
> hack"), variable 'zone' is never used. Remove it to avoid build warning.

Hi Liu,

Andrew already fixed that in the mmotm tree.

Thanks anyway

> 
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
>  mm/madvise.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/madvise.c b/mm/madvise.c
> index 460e19d60ba3..94b9d17331b9 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -879,7 +879,6 @@ static long madvise_remove(struct vm_area_struct *vma,
>  static int madvise_inject_error(int behavior,
>  		unsigned long start, unsigned long end)
>  {
> -	struct zone *zone;
>  	unsigned long size;
>  
>  	if (!capable(CAP_SYS_ADMIN))
> -- 
> 2.25.1
> 
>
diff mbox series

Patch

diff --git a/mm/madvise.c b/mm/madvise.c
index 460e19d60ba3..94b9d17331b9 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -879,7 +879,6 @@  static long madvise_remove(struct vm_area_struct *vma,
 static int madvise_inject_error(int behavior,
 		unsigned long start, unsigned long end)
 {
-	struct zone *zone;
 	unsigned long size;
 
 	if (!capable(CAP_SYS_ADMIN))