diff mbox series

[-next,2/9] rtlwifi: rtl8192c: fix comparison to bool warning in phy_common.c

Message ID 20200918102505.16036-3-zhengbin13@huawei.com (mailing list archive)
State Accepted
Commit 4cff897cb2f8e33332213fb8000c0a7187cc25f1
Delegated to: Kalle Valo
Headers show
Series rtlwifi: fix comparison to bool warnings | expand

Commit Message

Zheng Bin Sept. 18, 2020, 10:24 a.m. UTC 
Fixes coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c:1106:14-18: WARNING: Comparison to bool

Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.26.0.106.g9fadedd

Comments

Larry Finger Sept. 18, 2020, 8:47 p.m. UTC | #1 
On 9/18/20 5:24 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c:1106:14-18: WARNING: Comparison to bool
> 
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
>   drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Larry

> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
> index fc6c81291cf5..6a3deca404b9 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
> @@ -1103,7 +1103,7 @@ static void _rtl92c_phy_path_adda_on(struct ieee80211_hw *hw,
>   	u32 i;
> 
>   	pathon = is_patha_on ? 0x04db25a4 : 0x0b1b25a4;
> -	if (false == is2t) {
> +	if (!is2t) {
>   		pathon = 0x0bdb25a0;
>   		rtl_set_bbreg(hw, addareg[0], MASKDWORD, 0x0b1b25a0);
>   	} else {
> --
> 2.26.0.106.g9fadedd
>
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
index fc6c81291cf5..6a3deca404b9 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
@@ -1103,7 +1103,7 @@  static void _rtl92c_phy_path_adda_on(struct ieee80211_hw *hw,
 	u32 i;

 	pathon = is_patha_on ? 0x04db25a4 : 0x0b1b25a4;
-	if (false == is2t) {
+	if (!is2t) {
 		pathon = 0x0bdb25a0;
 		rtl_set_bbreg(hw, addareg[0], MASKDWORD, 0x0b1b25a0);
 	} else {