| Message ID | 1600786527-7343-2-git-send-email-akhilpo@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 63ca94adc03cff509d20b1306e48afccb44d5bdf |
| Headers | show |
| Series | [v2,1/2] drm/msm: Fix premature purging of BO | expand |
On Tue, Sep 22, 2020 at 08:25:27PM +0530, Akhil P Oommen wrote: > Leave the inuse count intact on map failure to keep the accounting > accurate. > > Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org> Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> > --- > drivers/gpu/drm/msm/msm_gem_vma.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c > index 80a8a26..f914ddb 100644 > --- a/drivers/gpu/drm/msm/msm_gem_vma.c > +++ b/drivers/gpu/drm/msm/msm_gem_vma.c > @@ -88,8 +88,10 @@ msm_gem_map_vma(struct msm_gem_address_space *aspace, > ret = aspace->mmu->funcs->map(aspace->mmu, vma->iova, sgt, > size, prot); > > - if (ret) > + if (ret) { > vma->mapped = false; > + vma->inuse--; > + } > > return ret; > } > -- > 2.7.4 >
diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c index 80a8a26..f914ddb 100644 --- a/drivers/gpu/drm/msm/msm_gem_vma.c +++ b/drivers/gpu/drm/msm/msm_gem_vma.c @@ -88,8 +88,10 @@ msm_gem_map_vma(struct msm_gem_address_space *aspace, ret = aspace->mmu->funcs->map(aspace->mmu, vma->iova, sgt, size, prot); - if (ret) + if (ret) { vma->mapped = false; + vma->inuse--; + } return ret; }
Leave the inuse count intact on map failure to keep the accounting accurate. Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org> --- drivers/gpu/drm/msm/msm_gem_vma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)