| Message ID | 20200926205542.9261-4-julien@xen.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xen/arm: Unbreak ACPI | expand |
Hello > On 26 Sep 2020, at 9:55 pm, Julien Grall <julien@xen.org> wrote: > > From: Julien Grall <jgrall@amazon.com> > > Dom0less requires a device-tree. However, since commit 6e3e77120378 > "xen/arm: setup: Relocate the Device-Tree later on in the boot", the > device-tree will not get unflatten when using ACPI. > > This will lead to a crash during boot. > > Given the complexity to setup dom0less with ACPI (for instance how to > assign device?), we should skip any code related to Dom0less when using > ACPI. > > Signed-off-by: Julien Grall <jgrall@amazon.com> Reviewed-by: Rahul Singh <rahul.singh@arm.com> Tested-by: Rahul Singh <rahul.singh@arm.com> > --- > xen/arch/arm/setup.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index f16b33fa87a2..35e5bee04efa 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -987,7 +987,8 @@ void __init start_xen(unsigned long boot_phys_offset, > > system_state = SYS_STATE_active; > > - create_domUs(); > + if ( acpi_disabled ) > + create_domUs(); > > domain_unpause_by_systemcontroller(dom0); > > -- > 2.17.1 > > Regards, Rahul
On Sat, 26 Sep 2020, Julien Grall wrote: > From: Julien Grall <jgrall@amazon.com> > > Dom0less requires a device-tree. However, since commit 6e3e77120378 > "xen/arm: setup: Relocate the Device-Tree later on in the boot", the > device-tree will not get unflatten when using ACPI. > > This will lead to a crash during boot. > > Given the complexity to setup dom0less with ACPI (for instance how to > assign device?), we should skip any code related to Dom0less when using > ACPI. Yeah... Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > Signed-off-by: Julien Grall <jgrall@amazon.com> > --- > xen/arch/arm/setup.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index f16b33fa87a2..35e5bee04efa 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -987,7 +987,8 @@ void __init start_xen(unsigned long boot_phys_offset, > > system_state = SYS_STATE_active; > > - create_domUs(); > + if ( acpi_disabled ) > + create_domUs(); > > domain_unpause_by_systemcontroller(dom0); > > -- > 2.17.1 >
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index f16b33fa87a2..35e5bee04efa 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -987,7 +987,8 @@ void __init start_xen(unsigned long boot_phys_offset, system_state = SYS_STATE_active; - create_domUs(); + if ( acpi_disabled ) + create_domUs(); domain_unpause_by_systemcontroller(dom0);