| Message ID | 20200928023543.70093-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: make two symbols static | expand |
On 2020-09-27 10:35 p.m., Jason Yan wrote: > This addresses the following sparse warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6: > warning: symbol 'dce110_set_cursor_position' was not declared. Should it > be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2785:6: > warning: symbol 'dce110_set_cursor_attribute' was not declared. Should > it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > index 1002ce9979dc..31a8d3452e83 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > @@ -2737,7 +2737,7 @@ static void program_output_csc(struct dc *dc, > } > } > > -void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx) > +static void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx) > { > struct dc_cursor_position pos_cpy = pipe_ctx->stream->cursor_position; > struct input_pixel_processor *ipp = pipe_ctx->plane_res.ipp; > @@ -2782,7 +2782,7 @@ void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx) > mi->funcs->set_cursor_position(mi, &pos_cpy, ¶m); > } > > -void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx) > +static void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx) > { > struct dc_cursor_attributes *attributes = &pipe_ctx->stream->cursor_attributes; > >
Applied. Thanks! Alex On Mon, Sep 28, 2020 at 10:06 AM Harry Wentland <harry.wentland@amd.com> wrote: > > On 2020-09-27 10:35 p.m., Jason Yan wrote: > > This addresses the following sparse warning: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6: > > warning: symbol 'dce110_set_cursor_position' was not declared. Should it > > be static? > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2785:6: > > warning: symbol 'dce110_set_cursor_attribute' was not declared. Should > > it be static? > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Jason Yan <yanaijie@huawei.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > > Harry > > > --- > > drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > > index 1002ce9979dc..31a8d3452e83 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > > @@ -2737,7 +2737,7 @@ static void program_output_csc(struct dc *dc, > > } > > } > > > > -void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx) > > +static void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx) > > { > > struct dc_cursor_position pos_cpy = pipe_ctx->stream->cursor_position; > > struct input_pixel_processor *ipp = pipe_ctx->plane_res.ipp; > > @@ -2782,7 +2782,7 @@ void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx) > > mi->funcs->set_cursor_position(mi, &pos_cpy, ¶m); > > } > > > > -void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx) > > +static void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx) > > { > > struct dc_cursor_attributes *attributes = &pipe_ctx->stream->cursor_attributes; > > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c index 1002ce9979dc..31a8d3452e83 100644 --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c @@ -2737,7 +2737,7 @@ static void program_output_csc(struct dc *dc, } } -void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx) +static void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx) { struct dc_cursor_position pos_cpy = pipe_ctx->stream->cursor_position; struct input_pixel_processor *ipp = pipe_ctx->plane_res.ipp; @@ -2782,7 +2782,7 @@ void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx) mi->funcs->set_cursor_position(mi, &pos_cpy, ¶m); } -void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx) +static void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx) { struct dc_cursor_attributes *attributes = &pipe_ctx->stream->cursor_attributes;
This addresses the following sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6: warning: symbol 'dce110_set_cursor_position' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2785:6: warning: symbol 'dce110_set_cursor_attribute' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)