| Message ID | 20200929135741.1.I8b447ca96abfbef5f298d77350e6c9d1d18d00f6@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | nvmem: qfprom: Avoid untouchable regions | expand |
Hi, On Tue, Sep 29, 2020 at 1:58 PM Evan Green <evgreen@chromium.org> wrote: > > Add an SoC-specific compatible string so that data can be attached > to it in the driver. > > Signed-off-by: Evan Green <evgreen@chromium.org> > --- > > Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > index 59aca6d22ff9b..b16c8e6a8c23d 100644 > --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > @@ -14,7 +14,9 @@ allOf: > > properties: > compatible: > - const: qcom,qfprom > + enum: > + - qcom,qfprom > + - qcom,sc7180-qfprom You don't want either/or. You want both. At the time Srinivas didn't see the point of having the SoC-specific compatible string here, but now that we have a reason for it maybe he'll be convinced? IMO you essentially want: items: - enum: - qcom,apq8064-qfprom - qcom,apq8084-qfprom - qcom,msm8974-qfprom - qcom,msm8916-qfprom - qcom,msm8996-qfprom - qcom,msm8998-qfprom - qcom,qcs404-qfprom - qcom,sc7180-qfprom - qcom,sdm845-qfprom - const: qcom,qfprom For some context: <https://lore.kernel.org/r/CAD=FV=WjvAWVmq3fTh=_f2p1Dv+sXg1RV-CqZr8KRgHe8_wT0w@mail.gmail.com/> -Doug > > reg: > # If the QFPROM is read-only OS image then only the corrected region > -- > 2.26.2 >
On Fri, Oct 2, 2020 at 3:20 PM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Tue, Sep 29, 2020 at 1:58 PM Evan Green <evgreen@chromium.org> wrote: > > > > Add an SoC-specific compatible string so that data can be attached > > to it in the driver. > > > > Signed-off-by: Evan Green <evgreen@chromium.org> > > --- > > > > Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > index 59aca6d22ff9b..b16c8e6a8c23d 100644 > > --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > @@ -14,7 +14,9 @@ allOf: > > > > properties: > > compatible: > > - const: qcom,qfprom > > + enum: > > + - qcom,qfprom > > + - qcom,sc7180-qfprom > > You don't want either/or. You want both. At the time Srinivas didn't > see the point of having the SoC-specific compatible string here, but > now that we have a reason for it maybe he'll be convinced? IMO you > essentially want: > > items: > - enum: > - qcom,apq8064-qfprom > - qcom,apq8084-qfprom > - qcom,msm8974-qfprom > - qcom,msm8916-qfprom > - qcom,msm8996-qfprom > - qcom,msm8998-qfprom > - qcom,qcs404-qfprom > - qcom,sc7180-qfprom > - qcom,sdm845-qfprom > - const: qcom,qfprom > > For some context: > <https://lore.kernel.org/r/CAD=FV=WjvAWVmq3fTh=_f2p1Dv+sXg1RV-CqZr8KRgHe8_wT0w@mail.gmail.com/> That makes sense, thanks Doug. Srini, do you want me to go fix up all the various device trees to add the soc-compatible string, or just sc7180? (Also, don't forget about my other question about whether you still want the keepout stuff in the core at the cost of added complexity). -Evan > > -Doug > > > > > > reg: > > # If the QFPROM is read-only OS image then only the corrected region > > -- > > 2.26.2 > >
On 03/10/2020 00:14, Evan Green wrote: >> You don't want either/or. You want both. At the time Srinivas didn't >> see the point of having the SoC-specific compatible string here, but >> now that we have a reason for it maybe he'll be convinced? IMO you >> essentially want: >> >> items: >> - enum: >> - qcom,apq8064-qfprom >> - qcom,apq8084-qfprom >> - qcom,msm8974-qfprom >> - qcom,msm8916-qfprom >> - qcom,msm8996-qfprom >> - qcom,msm8998-qfprom >> - qcom,qcs404-qfprom >> - qcom,sc7180-qfprom >> - qcom,sdm845-qfprom >> - const: qcom,qfprom >> >> For some context: >> <https://lore.kernel.org/r/CAD=FV=WjvAWVmq3fTh=_f2p1Dv+sXg1RV-CqZr8KRgHe8_wT0w@mail.gmail.com/> > That makes sense, thanks Doug. > > Srini, do you want me to go fix up all the various device trees to add > the soc-compatible string, or just sc7180? (Also, don't forget about > my other question about whether you still want the keepout stuff in > the core at the cost of added complexity). Lets keep the existing users as it for now! and we can still list compatibles in the bindings so that any new users (including sc7180) can start using them when needed! thanks, srini > > -Evan >
diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml index 59aca6d22ff9b..b16c8e6a8c23d 100644 --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml @@ -14,7 +14,9 @@ allOf: properties: compatible: - const: qcom,qfprom + enum: + - qcom,qfprom + - qcom,sc7180-qfprom reg: # If the QFPROM is read-only OS image then only the corrected region
Add an SoC-specific compatible string so that data can be attached to it in the driver. Signed-off-by: Evan Green <evgreen@chromium.org> --- Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)