diff mbox series

[v6,01/17] dt-bindings: mfd: syscon: add some compatible strings for Hisilicon

Message ID 20200930031712.2365-2-thunder.leizhen@huawei.com (mailing list archive)
State New, archived
Headers show
Series add support for Hisilicon SD5203 SoC | expand

Commit Message

Zhen Lei Sept. 30, 2020, 3:16 a.m. UTC
Add some compatible strings for Hisilicon controllers:
hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
hisilicon,peri-subctrl     --> HiP05/HiP06 PERI subsystem controller
hisilicon,dsa-subctrl      --> HiP05/HiP06 DSA subsystem controller

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Lee Jones Sept. 30, 2020, 7:11 a.m. UTC | #1
On Wed, 30 Sep 2020, Zhen Lei wrote:

> Add some compatible strings for Hisilicon controllers:
> hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
> hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
> hisilicon,peri-subctrl     --> HiP05/HiP06 PERI subsystem controller
> hisilicon,dsa-subctrl      --> HiP05/HiP06 DSA subsystem controller
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

This was already applied by the time you re-sent it.

Any reason for sending it again?
Zhen Lei Sept. 30, 2020, 7:21 a.m. UTC | #2
On 2020/9/30 15:11, Lee Jones wrote:
> On Wed, 30 Sep 2020, Zhen Lei wrote:
> 
>> Add some compatible strings for Hisilicon controllers:
>> hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
>> hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
>> hisilicon,peri-subctrl     --> HiP05/HiP06 PERI subsystem controller
>> hisilicon,dsa-subctrl      --> HiP05/HiP06 DSA subsystem controller
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> This was already applied by the time you re-sent it.
> 
> Any reason for sending it again?

Path 15 are modified. The Document patches except Patch 15 are applied,
but the config/DTS patches are not applied(They are applied after I re-sent).

>
Krzysztof Kozlowski Oct. 1, 2020, 6:27 a.m. UTC | #3
On Wed, 30 Sep 2020 at 05:19, Zhen Lei <thunder.leizhen@huawei.com> wrote:
>
> Add some compatible strings for Hisilicon controllers:
> hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
> hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
> hisilicon,peri-subctrl     --> HiP05/HiP06 PERI subsystem controller
> hisilicon,dsa-subctrl      --> HiP05/HiP06 DSA subsystem controller
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 049ec2ffc7f97e4..fc2e85004d363bf 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -40,7 +40,10 @@ properties:
>                - allwinner,sun50i-a64-system-controller
>                - microchip,sparx5-cpu-syscon
>                - mstar,msc313-pmsleep
> -
> +              - hisilicon,hi6220-sramctrl
> +              - hisilicon,pcie-sas-subctrl
> +              - hisilicon,peri-subctrl
> +              - hisilicon,dsa-subctrl

Add them in alphabetical order, not at the end of list.

Best regards,
Krzysztof
Lee Jones Oct. 1, 2020, 6:59 a.m. UTC | #4
On Wed, 30 Sep 2020, Leizhen (ThunderTown) wrote:

> 
> 
> On 2020/9/30 15:11, Lee Jones wrote:
> > On Wed, 30 Sep 2020, Zhen Lei wrote:
> > 
> >> Add some compatible strings for Hisilicon controllers:
> >> hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
> >> hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
> >> hisilicon,peri-subctrl     --> HiP05/HiP06 PERI subsystem controller
> >> hisilicon,dsa-subctrl      --> HiP05/HiP06 DSA subsystem controller
> >>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> >> ---
> >>  Documentation/devicetree/bindings/mfd/syscon.yaml | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > This was already applied by the time you re-sent it.
> > 
> > Any reason for sending it again?
> 
> Path 15 are modified. The Document patches except Patch 15 are applied,
> but the config/DTS patches are not applied(They are applied after I re-sent).

Could you please only send patches which have not been applied.
Zhen Lei Oct. 10, 2020, 10:01 a.m. UTC | #5
On 2020/10/1 14:59, Lee Jones wrote:
> On Wed, 30 Sep 2020, Leizhen (ThunderTown) wrote:
> 
>>
>>
>> On 2020/9/30 15:11, Lee Jones wrote:
>>> On Wed, 30 Sep 2020, Zhen Lei wrote:
>>>
>>>> Add some compatible strings for Hisilicon controllers:
>>>> hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
>>>> hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
>>>> hisilicon,peri-subctrl     --> HiP05/HiP06 PERI subsystem controller
>>>> hisilicon,dsa-subctrl      --> HiP05/HiP06 DSA subsystem controller
>>>>
>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 5 ++++-
>>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> This was already applied by the time you re-sent it.
>>>
>>> Any reason for sending it again?
>>
>> Path 15 are modified. The Document patches except Patch 15 are applied,
>> but the config/DTS patches are not applied(They are applied after I re-sent).
> 
> Could you please only send patches which have not been applied.

No experience. I'll pay attention next time.

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 049ec2ffc7f97e4..fc2e85004d363bf 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -40,7 +40,10 @@  properties:
               - allwinner,sun50i-a64-system-controller
               - microchip,sparx5-cpu-syscon
               - mstar,msc313-pmsleep
-
+              - hisilicon,hi6220-sramctrl
+              - hisilicon,pcie-sas-subctrl
+              - hisilicon,peri-subctrl
+              - hisilicon,dsa-subctrl
           - const: syscon
 
       - contains: