| Message ID | 20200930060008.42134-5-alexandru.ardelean@analog.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: adc: at91: misc driver cleanups | expand |
Hi, On 30/09/2020 09:00:08+0300, Alexandru Ardelean wrote: > Since the driver should be allowed to build without OF support, the > of_match_ptr() is redundant. > This can probably be squashed with the previous commit. Also, I think that you should really make the driver DT only else, the driver will carry dead code and there will be no reminder that a cleanup is needed. I can take care of that if you feel that this is more work than what you wanted to spend on this driver. > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > --- > drivers/iio/adc/at91_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 7d846a2852a5..473bffe84fbd 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = { > .id_table = at91_adc_ids, > .driver = { > .name = DRIVER_NAME, > - .of_match_table = of_match_ptr(at91_adc_dt_ids), > + .of_match_table = at91_adc_dt_ids, > .pm = &at91_adc_pm_ops, > }, > }; > -- > 2.17.1 >
On Wed, Sep 30, 2020 at 10:48 AM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > > Hi, > > On 30/09/2020 09:00:08+0300, Alexandru Ardelean wrote: > > Since the driver should be allowed to build without OF support, the > > of_match_ptr() is redundant. > > > > This can probably be squashed with the previous commit. > > Also, I think that you should really make the driver DT only else, the > driver will carry dead code and there will be no reminder that a cleanup > is needed. > > I can take care of that if you feel that this is more work than what you > wanted to spend on this driver. Ah, you're saying remove the old pdata? I can do that while waiting for other of my patches to go in. > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > > --- > > drivers/iio/adc/at91_adc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > > index 7d846a2852a5..473bffe84fbd 100644 > > --- a/drivers/iio/adc/at91_adc.c > > +++ b/drivers/iio/adc/at91_adc.c > > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = { > > .id_table = at91_adc_ids, > > .driver = { > > .name = DRIVER_NAME, > > - .of_match_table = of_match_ptr(at91_adc_dt_ids), > > + .of_match_table = at91_adc_dt_ids, > > .pm = &at91_adc_pm_ops, > > }, > > }; > > -- > > 2.17.1 > > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
On 30/09/2020 11:46:06+0300, Alexandru Ardelean wrote: > On Wed, Sep 30, 2020 at 10:48 AM Alexandre Belloni > <alexandre.belloni@bootlin.com> wrote: > > > > Hi, > > > > On 30/09/2020 09:00:08+0300, Alexandru Ardelean wrote: > > > Since the driver should be allowed to build without OF support, the > > > of_match_ptr() is redundant. > > > > > > > This can probably be squashed with the previous commit. > > > > Also, I think that you should really make the driver DT only else, the > > driver will carry dead code and there will be no reminder that a cleanup > > is needed. > > > > I can take care of that if you feel that this is more work than what you > > wanted to spend on this driver. > > Ah, you're saying remove the old pdata? Yes, since you are making the driver DT only, the pdata has to be removed, don't forget to also remove the header file. > I can do that while waiting for other of my patches to go in. > > > > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > > > --- > > > drivers/iio/adc/at91_adc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > > > index 7d846a2852a5..473bffe84fbd 100644 > > > --- a/drivers/iio/adc/at91_adc.c > > > +++ b/drivers/iio/adc/at91_adc.c > > > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = { > > > .id_table = at91_adc_ids, > > > .driver = { > > > .name = DRIVER_NAME, > > > - .of_match_table = of_match_ptr(at91_adc_dt_ids), > > > + .of_match_table = at91_adc_dt_ids, > > > .pm = &at91_adc_pm_ops, > > > }, > > > }; > > > -- > > > 2.17.1 > > > > > > > -- > > Alexandre Belloni, Bootlin > > Embedded Linux and Kernel engineering > > https://bootlin.com
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c index 7d846a2852a5..473bffe84fbd 100644 --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = { .id_table = at91_adc_ids, .driver = { .name = DRIVER_NAME, - .of_match_table = of_match_ptr(at91_adc_dt_ids), + .of_match_table = at91_adc_dt_ids, .pm = &at91_adc_pm_ops, }, };
Since the driver should be allowed to build without OF support, the of_match_ptr() is redundant. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> --- drivers/iio/adc/at91_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)