diff mbox series

i2c: aT91: remove legacy DMA left overs

Message ID 20200930145655.3044490-1-alexandre.belloni@bootlin.com (mailing list archive)
State New, archived
Headers show
Series i2c: aT91: remove legacy DMA left overs | expand

Commit Message

Alexandre Belloni Sept. 30, 2020, 2:56 p.m. UTC
Commit dc6df6e90de9 ("i2c: at91: remove legacy DMA support") removed legcy
DMA support from the driver. Remove the last use of the definitions from
linux/platform_data/dma-atmel.h and stop including this header.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/i2c/busses/i2c-at91-master.c | 1 -
 drivers/i2c/busses/i2c-at91.h        | 2 --
 2 files changed, 3 deletions(-)

Comments

Codrin Ciubotariu Oct. 10, 2020, 12:28 p.m. UTC | #1
On 30.09.2020 17:56, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Commit dc6df6e90de9 ("i2c: at91: remove legacy DMA support") removed legcy
> DMA support from the driver. Remove the last use of the definitions from
> linux/platform_data/dma-atmel.h and stop including this header.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

There is a capital 'T' in the subject, not sure it matters. Otherwise:

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks!
Wolfram Sang Nov. 3, 2020, 8:36 p.m. UTC | #2
On Wed, Sep 30, 2020 at 04:56:54PM +0200, Alexandre Belloni wrote:
> Commit dc6df6e90de9 ("i2c: at91: remove legacy DMA support") removed legcy
> DMA support from the driver. Remove the last use of the definitions from
> linux/platform_data/dma-atmel.h and stop including this header.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Fixed the typo in the commit message and applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c
index 66864f9cf7ac..1cceb6866689 100644
--- a/drivers/i2c/busses/i2c-at91-master.c
+++ b/drivers/i2c/busses/i2c-at91-master.c
@@ -26,7 +26,6 @@ 
 #include <linux/of_device.h>
 #include <linux/pinctrl/consumer.h>
 #include <linux/platform_device.h>
-#include <linux/platform_data/dma-atmel.h>
 #include <linux/pm_runtime.h>
 
 #include "i2c-at91.h"
diff --git a/drivers/i2c/busses/i2c-at91.h b/drivers/i2c/busses/i2c-at91.h
index eae673ae786c..942e9c3973bb 100644
--- a/drivers/i2c/busses/i2c-at91.h
+++ b/drivers/i2c/busses/i2c-at91.h
@@ -18,7 +18,6 @@ 
 #include <linux/dma-mapping.h>
 #include <linux/dmaengine.h>
 #include <linux/i2c.h>
-#include <linux/platform_data/dma-atmel.h>
 #include <linux/platform_device.h>
 
 #define AT91_I2C_TIMEOUT	msecs_to_jiffies(100)	/* transfer timeout */
@@ -123,7 +122,6 @@  struct at91_twi_pdata {
 	bool has_adv_dig_filtr;
 	bool has_ana_filtr;
 	bool has_clear_cmd;
-	struct at_dma_slave dma_slave;
 };
 
 struct at91_twi_dma {