| Message ID | 20200930232939.31131-1-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: accel: mma8452: Constify static struct attribute_group | expand |
On Thu, 1 Oct 2020 01:29:39 +0200 Rikard Falkeborn <rikard.falkeborn@gmail.com> wrote: > The only usage of mma8452_event_attribute_group is to assign its address > to the event_attrs field in the iio_info struct, which is a const > pointer. Make it const to allow the compiler to put it in read-only > memory. This was the only non-const static struct in drivers/iio. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> applied. Thanks, Jonathan > --- > drivers/iio/accel/mma8452.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index bf1d2c8afdbd..b0176d936423 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -1187,7 +1187,7 @@ static struct attribute *mma8452_event_attributes[] = { > NULL, > }; > > -static struct attribute_group mma8452_event_attribute_group = { > +static const struct attribute_group mma8452_event_attribute_group = { > .attrs = mma8452_event_attributes, > }; >
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index bf1d2c8afdbd..b0176d936423 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -1187,7 +1187,7 @@ static struct attribute *mma8452_event_attributes[] = { NULL, }; -static struct attribute_group mma8452_event_attribute_group = { +static const struct attribute_group mma8452_event_attribute_group = { .attrs = mma8452_event_attributes, };
The only usage of mma8452_event_attribute_group is to assign its address to the event_attrs field in the iio_info struct, which is a const pointer. Make it const to allow the compiler to put it in read-only memory. This was the only non-const static struct in drivers/iio. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/iio/accel/mma8452.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)