drm/i915: constify mode in crtc_mode_fixup
diff mbox

Message ID 1342773045-779-1-git-send-email-daniel.vetter@ffwll.ch
State New, archived
Headers show

Commit Message

Daniel Vetter July 20, 2012, 8:30 a.m. UTC
Laurent Pinchart missed this when sending in is giant constify patch:

commit e811f5ae19043b2ac2c28e147a4274038e655598
Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date:   Tue Jul 17 17:56:50 2012 +0200

    drm: Make the .mode_fixup() operations mode argument a const pointer

Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart July 20, 2012, 9:46 a.m. UTC | #1
Hi Daniel,

On Friday 20 July 2012 10:30:45 Daniel Vetter wrote:
> Laurent Pinchart missed this when sending in is giant constify patch:

My bad, sorry. I would have sworn I had compiled all the x86 DRM drivers, that 
warning must have slipped through the cracks somehow. Thank you for the fix.

> commit e811f5ae19043b2ac2c28e147a4274038e655598
> Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Date:   Tue Jul 17 17:56:50 2012 +0200
> 
>     drm: Make the .mode_fixup() operations mode argument a const pointer
> 
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Acked-by; Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c index 1802c30..fdd7671 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3575,7 +3575,7 @@ void intel_encoder_destroy(struct drm_encoder
> *encoder) }
> 
>  static bool intel_crtc_mode_fixup(struct drm_crtc *crtc,
> -				  struct drm_display_mode *mode,
> +				  const struct drm_display_mode *mode,
>  				  struct drm_display_mode *adjusted_mode)
>  {
>  	struct drm_device *dev = crtc->dev;
Daniel Vetter July 23, 2012, 9:35 a.m. UTC | #2
On Fri, Jul 20, 2012 at 11:46:21AM +0200, Laurent Pinchart wrote:
> Hi Daniel,
> 
> On Friday 20 July 2012 10:30:45 Daniel Vetter wrote:
> > Laurent Pinchart missed this when sending in is giant constify patch:
> 
> My bad, sorry. I would have sworn I had compiled all the x86 DRM drivers, that 
> warning must have slipped through the cracks somehow. Thank you for the fix.
> 
> > commit e811f5ae19043b2ac2c28e147a4274038e655598
> > Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Date:   Tue Jul 17 17:56:50 2012 +0200
> > 
> >     drm: Make the .mode_fixup() operations mode argument a const pointer
> > 
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Acked-by; Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Picked up for -fixes, thanks for the ack.
-Daniel

Patch
diff mbox

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 1802c30..fdd7671 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3575,7 +3575,7 @@  void intel_encoder_destroy(struct drm_encoder *encoder)
 }
 
 static bool intel_crtc_mode_fixup(struct drm_crtc *crtc,
-				  struct drm_display_mode *mode,
+				  const struct drm_display_mode *mode,
 				  struct drm_display_mode *adjusted_mode)
 {
 	struct drm_device *dev = crtc->dev;