drm, ast_fb: Fix a small leak in astfb_create()

Commit Message

Jesper Juhl July 20, 2012, 6:46 p.m. UTC

We have this code:

...
	sysram = vmalloc(size);
	if (!sysram)
		return -ENOMEM;

	info = framebuffer_alloc(0, device);
	if (!info) {
		ret = -ENOMEM;
		goto out;
	}
...

We'll leak the memory allocated to 'sysram' if the framebuffer_alloc()
call fails and the variable goes out of scope.

Signed-off-by: Jesper Juhl <[e-mail]>
---
 drivers/gpu/drm/ast/ast_fb.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index 2fc8e9e..260a760 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -180,6 +180,7 @@  static int astfb_create(struct ast_fbdev *afbdev,
 
 	info = framebuffer_alloc(0, device);
 	if (!info) {
+		vfree(sysram);
 		ret = -ENOMEM;
 		goto out;
 	}