From patchwork Wed Jul 25 22:35:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carsten Emde X-Patchwork-Id: 1239811 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 232EF3FD4F for ; Wed, 25 Jul 2012 22:40:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E3DF9F4EC for ; Wed, 25 Jul 2012 15:40:41 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from toro.web-alm.net (toro.web-alm.net [62.245.132.31]) by gabe.freedesktop.org (Postfix) with ESMTP id A89819E8F2 for ; Wed, 25 Jul 2012 15:40:11 -0700 (PDT) Received: from toro.web-alm.net (localhost.localdomain [127.0.0.1]) by toro.web-alm.net (8.12.11.20060308/8.12.11/Web-Alm-2003112001) with ESMTP id q6PMe9RV025537; Thu, 26 Jul 2012 00:40:09 +0200 Received: from rack3slot8.osadl.org (uucp@localhost) by toro.web-alm.net (8.12.11.20060308/8.12.10/Submit/Web-Alm-2003112001) with bsmtp id q6PMe8bY025465; Thu, 26 Jul 2012 00:40:08 +0200 Received: from rack3slot1.osadl.org (rack3slot8.osadl.org [127.0.0.1]) by rack3slot8.osadl.org (8.13.8/8.13.8/CE-2010120801) with ESMTP id q6PMZMIP017473; Thu, 26 Jul 2012 00:35:22 +0200 Message-ID: <501074AA.1070905@osadl.org> Date: Thu, 26 Jul 2012 00:35:22 +0200 From: Carsten Emde Organization: Open Source Automation Development Lab (OSADL) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Thunderbird/3.1.16 MIME-Version: 1.0 To: Daniel Vetter References: <20120426170844.GG5156@phenom.ffwll.local> <1335461132-11664-1-git-send-email-daniel.vetter@ffwll.ch> <4F999E10.2060404@osadl.org> <20120426193004.GJ5156@phenom.ffwll.local> <4F9AFF00.8010705@osadl.org> <20120602230800.GB4737@phenom.ffwll.local> <50081313.8070206@osadl.org> <50088F7D.1020008@osadl.org> <20120720081046.GA5544@phenom.ffwll.local> <500E4F12.9040906@osadl.org> In-Reply-To: <500E4F12.9040906@osadl.org> X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on rack3slot8.osadl.org X-Virus-Status: Clean X-Spam-Status: No, score=-101.0 required=5.0 tests=ALL_TRUSTED, T_RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on rack3slot8.osadl.org Cc: Daniel Vetter , Intel Graphics Development Subject: Re: [Intel-gfx] [PATCH] properly enable the blc controller on the right pipe X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org On 07/24/2012 09:30 AM, Carsten Emde wrote: > On 07/20/2012 10:10 AM, Daniel Vetter wrote: >> On Fri, Jul 20, 2012 at 12:51:41AM +0200, Carsten Emde wrote: >>> On 07/19/2012 04:40 PM, Daniel Vetter wrote: >>>> Well, the backlight-confusion branch had a bug and outright disabled >>>> the intel backlight :( drm-intel-next-queued should have fixes for all >>>> the backlight goofus I've accidentally created, so testing feedback on >>>> that branch would be highly appreciated. >>> This branch is now broken again. The original drm-intel-next-queued >>> branch works well (it still has the quirk), but after I reverted the >>> Acer quirk, the screen remains dark. >>> >>> I double-checked it and used exactly the same patch to revert the >>> quirk in the two trees: The backlight-confusion branch works, and >>> the drm-intel-next-queued branch does not. >>> >>> I then used drivers/gpu/drm/i915/intel_panel.c from >>> backlight-confusion in drm-intel-next-queued and - it worked again. >>> When testing the two differences separately it turned out this patch >>> did the magic: >> >> Yeah, I guess your system only worked whith the old code because it >> accidentally disabled the entire backlight stuff. Now that that doesn't >> happen any more, it's as broken as ever. >> >> I'll look into creating another patch, afaict from digging through git >> history, this backlight combination mode is totally bogus. But if we kill >> it, a few machines will resume with dimmed backlight, because we don't >> restore the lbpc register properly. > After all that hassle and bearing in mind that we found only two > notebooks so far, Acer Aspire 5732Z and 5734Z, that suffer from this > backlight inversion problem, shouldn't we simply return to the quirk > solution? I would quickly add the data of the other Acer to the > backlight quirks, send a rebased patch, and we are all set. These are the data of the other Acer Aspire that needs backlight inversion. Index: linux-git/drivers/gpu/drm/i915/intel_display.c Do you wish me to submit this as a regular patch? -Carsten. =================================================================== --- linux-git.orig/drivers/gpu/drm/i915/intel_display.c +++ linux-git/drivers/gpu/drm/i915/intel_display.c @@ -6877,7 +6877,8 @@ static struct intel_quirk intel_quirks[] /* Sony Vaio Y cannot use SSC on LVDS */ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable }, - /* Acer Aspire 5734Z must invert backlight brightness */ + /* Acer Aspire 5732Z and 5734Z must invert backlight brightness */ + { 0x2a42, 0x1025, 0x0212, quirk_invert_brightness }, { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness }, };