diff mbox

[2/3] gma: psb_intel_crtc: Drop crtc_enable flag.

Message ID 20120811121555.GD3089@alittletooquiet.net (mailing list archive)
State New, archived
Headers show

Commit Message

Forest Bond Aug. 11, 2012, 12:15 p.m. UTC 
From: Forest Bond <forest.bond@rapidrollout.com>

This is set when setting DPMS on and off, but it isn't checked anywhere,
so just remove it.

Signed-off-by: Forest Bond <forest.bond@rapidrollout.com>
---
 drivers/gpu/drm/gma500/cdv_intel_display.c |    2 --
 drivers/gpu/drm/gma500/psb_intel_drv.h     |    1 -
 2 files changed, 0 insertions(+), 3 deletions(-)

Comments

Forest Bond Aug. 12, 2012, 2:04 p.m. UTC | #1 
Hi,

> Subject: Re: [PATCH 2/3] gma: psb_intel_crtc: Drop crtc_enable flag.

So obviously this should have read "gma500: ..."  Let me know if I should
resend.

Thanks,
Forest
Alan Cox Aug. 12, 2012, 3:25 p.m. UTC | #2 
On Sun, 12 Aug 2012 10:04:47 -0400
Forest Bond <forest@alittletooquiet.net> wrote:

> Hi,
> 
> > Subject: Re: [PATCH 2/3] gma: psb_intel_crtc: Drop crtc_enable flag.
> 
> So obviously this should have read "gma500: ..."  Let me know if I should
> resend.

No need. I'll pick these up and test them on the problem board here as
well.

Alan
diff mbox

Patch

diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c
index 883a9f3..2100aff 100644
--- a/drivers/gpu/drm/gma500/cdv_intel_display.c
+++ b/drivers/gpu/drm/gma500/cdv_intel_display.c
@@ -841,7 +841,6 @@  static void cdv_intel_crtc_dpms(struct drm_crtc *crtc, int mode)
 		/* Give the overlay scaler a chance to enable
 		 * if it's on this pipe */
 		/* psb_intel_crtc_dpms_video(crtc, true); TODO */
-		psb_intel_crtc->crtc_enable = true;
 		break;
 	case DRM_MODE_DPMS_OFF:
 		if (!psb_intel_crtc->active)
@@ -893,7 +892,6 @@  static void cdv_intel_crtc_dpms(struct drm_crtc *crtc, int mode)
 		/* Wait for the clocks to turn off. */
 		udelay(150);
 		cdv_intel_update_watermark(dev, crtc);
-		psb_intel_crtc->crtc_enable = false;
 		break;
 	}
 	/*Set FIFO Watermarks*/
diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h b/drivers/gpu/drm/gma500/psb_intel_drv.h
index ebe1a28..e179c36 100644
--- a/drivers/gpu/drm/gma500/psb_intel_drv.h
+++ b/drivers/gpu/drm/gma500/psb_intel_drv.h
@@ -190,7 +190,6 @@  struct psb_intel_crtc {
 	u32 mode_flags;
 
 	bool active;
-	bool crtc_enable;
 
 	/* Saved Crtc HW states */
 	struct psb_intel_crtc_state *crtc_state;