Patchwork [linux-dvb] TechnoTrend C-1501 - Locking issues on 388Mhz

login
register
mail settings
Submitter klaas de waal
Date March 25, 2009, 8:53 p.m.
Message ID <7b41dd970903251353n46f55bbfg687c1cfa42c5b824@mail.gmail.com>
Download mbox | patch
Permalink /patch/14405/
State Accepted
Headers show

Comments

klaas de waal - March 25, 2009, 8:53 p.m.
(2nd try, this should be now  in "plain text" instead of HTML)

Hi Hermann,

Thanks for your "howto" on making a proper patch.
After a "make commit" in my local v4l-dvb tree, and filling in the
template I got the following output.
I confess I do not know if this has now ended up somewhere in
linuxtv.org or that it is just local.
However, here it is:

changeset:   11143:f10e05176a88
tag:         tip
user:        Klaas de Waal <klaas.de.waal@gmail.com>
date:        Tue Mar 24 22:59:44 2009 +0100
files:       linux/drivers/media/common/tuners/tda827x.c
linux/drivers/media/dvb/ttpci/budget-ci.c
description:
Separate tuning table for DVB-C solves tuning problem at 388MHz.

From: Klaas de Waal <klaas.de.waal@gmail.com>

TechnoTrend C-1501 DVB-C card does not lock on 388MHz.
I assume that existing frequency table is valid for DVB-T. This is suggested
by the name of the table: tda827xa_dvbt.
Added a table for DVB-C with the name tda827xa_dvbc.
Added runtime selection of the DVB-C table when the tuner is type FE_QAM.
This should leave the behaviour of this driver with with DVB_T tuners unchanged.
This modification is in file tda827x.c

The tda827x.c gives the following warning message when debug=1 :

tda827x: tda827x_config not defined, cannot set LNA gain!

Solved this by adding a tda827x_config struct in budget-ci.c.

Priority: normal

Signed-off-by: Klaas de Waal <klaas.de.waal@gmail.com>


I have attached the result of "hg diff > tda827x_dvb-c_tuning_table.patch.

Patch is based on the "hg clone" done 23 march.
Tested again, now with Linux kernel 2.6.28.9.

Cheers,
Klaas.
hermann pitton - March 26, 2009, 11:51 p.m.
Hi Klaas,

Am Mittwoch, den 25.03.2009, 21:53 +0100 schrieb klaas de waal:
> (2nd try, this should be now  in "plain text" instead of HTML)
> 
> Hi Hermann,
> 
> Thanks for your "howto" on making a proper patch.
> After a "make commit" in my local v4l-dvb tree, and filling in the
> template I got the following output.
> I confess I do not know if this has now ended up somewhere in
> linuxtv.org or that it is just local.
> However, here it is:

your patches are still local, but they are at least on the proper list
now. Without starting with [PATCH] in the subject Mauro's scripts to add
them to patchwork automatically likely will still not find them.

As said before, as long nobody has the documentation for that tuner and
knows better somehow, your attempt to improve it is valid in my eyes and
was usual practice in such cases previously.

It would of course be fine if Oliver and/or Michael could review it and
eventually give an ACK or NACK with some reasons.

I came to it, because you initially reported the problem erroneously on
the saa7134 driver, but I'm not sure how I can help further with it now,
except for eventually remaining checkpatch.pl stuff and such.

Cheers,
Hermann

> changeset:   11143:f10e05176a88
> tag:         tip
> user:        Klaas de Waal <klaas.de.waal@gmail.com>
> date:        Tue Mar 24 22:59:44 2009 +0100
> files:       linux/drivers/media/common/tuners/tda827x.c
> linux/drivers/media/dvb/ttpci/budget-ci.c
> description:
> Separate tuning table for DVB-C solves tuning problem at 388MHz.
> 
> From: Klaas de Waal <klaas.de.waal@gmail.com>
> 
> TechnoTrend C-1501 DVB-C card does not lock on 388MHz.
> I assume that existing frequency table is valid for DVB-T. This is suggested
> by the name of the table: tda827xa_dvbt.
> Added a table for DVB-C with the name tda827xa_dvbc.
> Added runtime selection of the DVB-C table when the tuner is type FE_QAM.
> This should leave the behaviour of this driver with with DVB_T tuners unchanged.
> This modification is in file tda827x.c
> 
> The tda827x.c gives the following warning message when debug=1 :
> 
> tda827x: tda827x_config not defined, cannot set LNA gain!
> 
> Solved this by adding a tda827x_config struct in budget-ci.c.
> 
> Priority: normal
> 
> Signed-off-by: Klaas de Waal <klaas.de.waal@gmail.com>
> 
> 
> I have attached the result of "hg diff > tda827x_dvb-c_tuning_table.patch.
> 
> Patch is based on the "hg clone" done 23 march.
> Tested again, now with Linux kernel 2.6.28.9.
> 
> Cheers,
> Klaas.

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mauro Carvalho Chehab - March 27, 2009, 12:09 a.m.
On Fri, 27 Mar 2009 00:51:43 +0100
hermann pitton <hermann-pitton@arcor.de> wrote:

> Hi Klaas,
> 
> Am Mittwoch, den 25.03.2009, 21:53 +0100 schrieb klaas de waal:
> > (2nd try, this should be now  in "plain text" instead of HTML)
> > 
> > Hi Hermann,
> > 
> > Thanks for your "howto" on making a proper patch.
> > After a "make commit" in my local v4l-dvb tree, and filling in the
> > template I got the following output.
> > I confess I do not know if this has now ended up somewhere in
> > linuxtv.org or that it is just local.
> > However, here it is:
> 
> your patches are still local, but they are at least on the proper list
> now. Without starting with [PATCH] in the subject Mauro's scripts to add
> them to patchwork automatically likely will still not find them.

The patchwork scripts are the ones that came with the product. They are not
developed by me ;)

Anyway, if patchwork didn't catch is because the inlined patch is broken, or it is
not inlined and were attached with a wrong mime type.


Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
hermann pitton - March 27, 2009, 12:46 a.m.
Am Donnerstag, den 26.03.2009, 21:09 -0300 schrieb Mauro Carvalho
Chehab:
> On Fri, 27 Mar 2009 00:51:43 +0100
> hermann pitton <hermann-pitton@arcor.de> wrote:
> 
> > Hi Klaas,
> > 
> > Am Mittwoch, den 25.03.2009, 21:53 +0100 schrieb klaas de waal:
> > > (2nd try, this should be now  in "plain text" instead of HTML)
> > > 
> > > Hi Hermann,
> > > 
> > > Thanks for your "howto" on making a proper patch.
> > > After a "make commit" in my local v4l-dvb tree, and filling in the
> > > template I got the following output.
> > > I confess I do not know if this has now ended up somewhere in
> > > linuxtv.org or that it is just local.
> > > However, here it is:
> > 
> > your patches are still local, but they are at least on the proper list
> > now. Without starting with [PATCH] in the subject Mauro's scripts to add
> > them to patchwork automatically likely will still not find them.
> 
> The patchwork scripts are the ones that came with the product. They are not
> developed by me ;)
> 
> Anyway, if patchwork didn't catch is because the inlined patch is broken, or it is
> not inlined and were attached with a wrong mime type.
> 

Oh well, I still would prefer to have comments from such closest to that
driver and related tuners, instead serving that "product".

There is more drifting around and it can be prepared to fit in to such
rules. My concern is that it will arrive there then without much
problems, but outstanding discussions are only postponed.

If I'm wrong, even better.

Cheers,
Hermann


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mauro Carvalho Chehab - March 27, 2009, 1:02 a.m.
On Fri, 27 Mar 2009 01:46:50 +0100
hermann pitton <hermann-pitton@arcor.de> wrote:

> 
> Am Donnerstag, den 26.03.2009, 21:09 -0300 schrieb Mauro Carvalho
> Chehab:
> > On Fri, 27 Mar 2009 00:51:43 +0100
> > hermann pitton <hermann-pitton@arcor.de> wrote:
> > 
> > > Hi Klaas,
> > > 
> > > Am Mittwoch, den 25.03.2009, 21:53 +0100 schrieb klaas de waal:
> > > > (2nd try, this should be now  in "plain text" instead of HTML)
> > > > 
> > > > Hi Hermann,
> > > > 
> > > > Thanks for your "howto" on making a proper patch.
> > > > After a "make commit" in my local v4l-dvb tree, and filling in the
> > > > template I got the following output.
> > > > I confess I do not know if this has now ended up somewhere in
> > > > linuxtv.org or that it is just local.
> > > > However, here it is:
> > > 
> > > your patches are still local, but they are at least on the proper list
> > > now. Without starting with [PATCH] in the subject Mauro's scripts to add
> > > them to patchwork automatically likely will still not find them.
> > 
> > The patchwork scripts are the ones that came with the product. They are not
> > developed by me ;)
> > 
> > Anyway, if patchwork didn't catch is because the inlined patch is broken, or it is
> > not inlined and were attached with a wrong mime type.
> > 
> 
> Oh well, I still would prefer to have comments from such closest to that
> driver and related tuners, instead serving that "product".
> 
> There is more drifting around and it can be prepared to fit in to such
> rules. My concern is that it will arrive there then without much
> problems, but outstanding discussions are only postponed.
> 
> If I'm wrong, even better.

The point is that sending a broken patch won't work, anyway, since they can't
be applied. The advantage of the tool is that it is clear to everyone that the
patch is ok (so, patchwork picked), or if it is line-wrapped or is not inlined,
creating troubles for people to review and apply.


Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
hermann pitton - March 27, 2009, 1:39 a.m.
Am Donnerstag, den 26.03.2009, 22:02 -0300 schrieb Mauro Carvalho
Chehab:
> On Fri, 27 Mar 2009 01:46:50 +0100
> hermann pitton <hermann-pitton@arcor.de> wrote:
> 
> > 
> > Am Donnerstag, den 26.03.2009, 21:09 -0300 schrieb Mauro Carvalho
> > Chehab:
> > > On Fri, 27 Mar 2009 00:51:43 +0100
> > > hermann pitton <hermann-pitton@arcor.de> wrote:
> > > 
> > > > Hi Klaas,
> > > > 
> > > > Am Mittwoch, den 25.03.2009, 21:53 +0100 schrieb klaas de waal:
> > > > > (2nd try, this should be now  in "plain text" instead of HTML)
> > > > > 
> > > > > Hi Hermann,
> > > > > 
> > > > > Thanks for your "howto" on making a proper patch.
> > > > > After a "make commit" in my local v4l-dvb tree, and filling in the
> > > > > template I got the following output.
> > > > > I confess I do not know if this has now ended up somewhere in
> > > > > linuxtv.org or that it is just local.
> > > > > However, here it is:
> > > > 
> > > > your patches are still local, but they are at least on the proper list
> > > > now. Without starting with [PATCH] in the subject Mauro's scripts to add
> > > > them to patchwork automatically likely will still not find them.
> > > 
> > > The patchwork scripts are the ones that came with the product. They are not
> > > developed by me ;)
> > > 
> > > Anyway, if patchwork didn't catch is because the inlined patch is broken, or it is
> > > not inlined and were attached with a wrong mime type.
> > > 
> > 
> > Oh well, I still would prefer to have comments from such closest to that
> > driver and related tuners, instead serving that "product".
> > 
> > There is more drifting around and it can be prepared to fit in to such
> > rules. My concern is that it will arrive there then without much
> > problems, but outstanding discussions are only postponed.
> > 
> > If I'm wrong, even better.
> 
> The point is that sending a broken patch won't work, anyway, since they can't
> be applied. The advantage of the tool is that it is clear to everyone that the
> patch is ok (so, patchwork picked), or if it is line-wrapped or is not inlined,
> creating troubles for people to review and apply.

Mauro, that is acceptable for me.

It loads work off from you and others and within the flood of patches we
see that is OK. To talk others to that to follow such rules is a great
annoyance and I ended up several times without further replies.

But my main concern is, if it once arrived at patchwork formally, it is
out of sight for most of us and might miss proper review, except you are
sure you can always guarantee that. I don't want to start to argue about
all what happened in the past.

So, at least, if some patch arrived there mysteriously ;), the
linux-media list should be informed that it is there now and last time
to speak off, in case anything is not fully clear, before vanishing into
some black hole until you find it in the next kernel release ...

Cheers,
Hermann




--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mauro Carvalho Chehab - March 27, 2009, 10:38 a.m.
On Fri, 27 Mar 2009 02:39:07 +0100
hermann pitton <hermann-pitton@arcor.de> wrote:

> But my main concern is, if it once arrived at patchwork formally, it is
> out of sight for most of us and might miss proper review, except you are
> sure you can always guarantee that. I don't want to start to argue about
> all what happened in the past.
> 
> So, at least, if some patch arrived there mysteriously ;), the
> linux-media list should be informed that it is there now and last time
> to speak off, in case anything is not fully clear, before vanishing into
> some black hole until you find it in the next kernel release ...

The only way to send patches to patchwork is to submit it via linux-media list.
There's no other way. So, all patch discussions and reviews should happen at
the ML, by replying at the patch email (or by replying another reply).
Patchwork will keep track of such replies as well.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
hermann pitton - March 27, 2009, 11:23 p.m.
Hi,

Am Freitag, den 27.03.2009, 07:38 -0300 schrieb Mauro Carvalho Chehab:
> On Fri, 27 Mar 2009 02:39:07 +0100
> hermann pitton <hermann-pitton@arcor.de> wrote:
> 
> > But my main concern is, if it once arrived at patchwork formally, it is
> > out of sight for most of us and might miss proper review, except you are
> > sure you can always guarantee that. I don't want to start to argue about
> > all what happened in the past.
> > 
> > So, at least, if some patch arrived there mysteriously ;), the
> > linux-media list should be informed that it is there now and last time
> > to speak off, in case anything is not fully clear, before vanishing into
> > some black hole until you find it in the next kernel release ...
> 
> The only way to send patches to patchwork is to submit it via linux-media list.
> There's no other way. So, all patch discussions and reviews should happen at
> the ML, by replying at the patch email (or by replying another reply).
> Patchwork will keep track of such replies as well.
> 

What happened so far with this patches is quite funny,
for me some black hole seems to be involved.

Klaas did send them the first time, also directly to me, on Tue, 24 Mar
2009 23:14:11 +0100.

Now I can see you have pulled them in already on Wednesday.
http://linuxtv.org/hg/v4l-dvb/rev/5efa9fbc8a88

There is no trace anymore on patchwork visible to me.
http://patchwork.kernel.org/project/linux-media/list
So I don't know how you processed them.

Most confusing is, that Klaas obviously did not receive a mail
notification from linuxtv-commits that his patch came in.

Last message date: Fri Feb 15 19:45:02 CET 2008
Archived on: Fri Feb 15 19:45:04 CET 2008 

Is it broken or only the archive not up to date?

Why else he would have posted a second time on
Wed, 25 Mar 2009 21:53:02 +0100 not knowing anything about the status of
his patches, which made me believe I should try to help him?

The timestamp on your mercurial commit of them is
Wed Mar 25 20:53:02 2009 +0000 (2 days ago)
That is the time when his second email arrived converted to Greenwich
time? Or how could you commit within the same second that mail arrived?

This is the time the patches have on both of his original mails.
--- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
--- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000

How can I ever know when they were really added and if they went through
patchwork :)

I was just about to suggest Klaas should try again with [PATCH] in the
subject until they are listed at patchwork.

Cheers,
Hermann








--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
hermann pitton - March 28, 2009, 3:03 a.m.
[snip]
> This is the time the patches have on both of his original mails.
> --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
> --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000

Hmm, how this could ever happen?

I'm not able to copy and paste this from evolution with even the
recommended preformatted option enabled. How I could ever submit any
further patches?

> How can I ever know when they were really added and if they went through
> patchwork :)

So I tried several editors and did still provide such BS.

The last time I remember to have seen such was in 2005 with SECAM L' and
it was going on over half a year.

Cheers,
Hermann



--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mauro Carvalho Chehab - March 28, 2009, 3:58 a.m.
On Sat, 28 Mar 2009 00:23:55 +0100
hermann pitton <hermann-pitton@arcor.de> wrote:

> Hi,
> 
> Am Freitag, den 27.03.2009, 07:38 -0300 schrieb Mauro Carvalho Chehab:
> > On Fri, 27 Mar 2009 02:39:07 +0100
> > hermann pitton <hermann-pitton@arcor.de> wrote:
> > 
> > > But my main concern is, if it once arrived at patchwork formally, it is
> > > out of sight for most of us and might miss proper review, except you are
> > > sure you can always guarantee that. I don't want to start to argue about
> > > all what happened in the past.
> > > 
> > > So, at least, if some patch arrived there mysteriously ;), the
> > > linux-media list should be informed that it is there now and last time
> > > to speak off, in case anything is not fully clear, before vanishing into
> > > some black hole until you find it in the next kernel release ...
> > 
> > The only way to send patches to patchwork is to submit it via linux-media list.
> > There's no other way. So, all patch discussions and reviews should happen at
> > the ML, by replying at the patch email (or by replying another reply).
> > Patchwork will keep track of such replies as well.
> > 
> 
> What happened so far with this patches is quite funny,
> for me some black hole seems to be involved.
> 
> Klaas did send them the first time, also directly to me, on Tue, 24 Mar
> 2009 23:14:11 +0100.
> 
> Now I can see you have pulled them in already on Wednesday.
> http://linuxtv.org/hg/v4l-dvb/rev/5efa9fbc8a88
> 
> There is no trace anymore on patchwork visible to me.
> http://patchwork.kernel.org/project/linux-media/list
> So I don't know how you processed them.

The above link uses the default patchwork filtering. By default it shows only
patches where there's an action required (e. g. New or Under Review patches).

To view a full list of the patches, you need to click at filters and select any.

You'll see all patches:
	http://patchwork.kernel.org/project/linux-media/list/?state=*

In the specific case od Klaas, this is his patch:

http://patchwork.kernel.org/patch/14405/

> Most confusing is, that Klaas obviously did not receive a mail
> notification from linuxtv-commits that his patch came in.

> 
> Last message date: Fri Feb 15 19:45:02 CET 2008
> Archived on: Fri Feb 15 19:45:04 CET 2008 
> 
> Is it broken or only the archive not up to date?
> 

I've received the notification here:

From: Patch from klaas de waal  <hg-commit@linuxtv.org>
To: linuxtv-commits@linuxtv.org
Cc: , Mauro Carvalho Chehab <mchehab@redhat.com>, klaas de waal <klaas.de.waal@gmail.com>
Subject: [linuxtv-commits] [hg:v4l-dvb] tda827x: fix locking issues with DVB-C
Date: Fri, 27 Mar 2009 18:05:01 +0100
Reply-To: klaas de waal via Mercurial <klaas.de.waal@gmail.com>
Sender: linuxtv-commits-bounces@linuxtv.org

The patch number 11236 was added via Mauro Carvalho Chehab <mchehab@redhat.com>
to http://linuxtv.org/hg/v4l-dvb master development tree.

Klaas should be received this also. Maybe some anti-spam filtering on his side?

You'll probably see this also at the linuxtv-commits archives.

> Why else he would have posted a second time on
> Wed, 25 Mar 2009 21:53:02 +0100 not knowing anything about the status of
> his patches, which made me believe I should try to help him?
> 
> The timestamp on your mercurial commit of them is
> Wed Mar 25 20:53:02 2009 +0000 (2 days ago)
> That is the time when his second email arrived converted to Greenwich
> time? Or how could you commit within the same second that mail arrived?

> This is the time the patches have on both of his original mails.
> --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
> --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000

The import scripts will try to preserve the original date of the sent email.

So, the date there is when the code were presented to public.

> How can I ever know when they were really added and if they went through
> patchwork :)
> 
> I was just about to suggest Klaas should try again with [PATCH] in the
> subject until they are listed at patchwork.

If the patch was received by patchwork, and "disappeared", all you need to do
is to click on filter and select a proper filter, like:

http://patchwork.kernel.org/project/linux-media/list/?submitter=klaas&state=*

This will present all patches authored by "klaas", and their state. Ah, if you
click on the patch, you'll see all the patch history, including the
sent/received emails. Even this email should be added there by patchwork ;)

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
hermann pitton - March 28, 2009, 4:32 a.m.
Am Samstag, den 28.03.2009, 00:58 -0300 schrieb Mauro Carvalho Chehab:
> On Sat, 28 Mar 2009 00:23:55 +0100
> hermann pitton <hermann-pitton@arcor.de> wrote:
> 
> > Hi,
> > 
> > Am Freitag, den 27.03.2009, 07:38 -0300 schrieb Mauro Carvalho Chehab:
> > > On Fri, 27 Mar 2009 02:39:07 +0100
> > > hermann pitton <hermann-pitton@arcor.de> wrote:
> > > 
> > > > But my main concern is, if it once arrived at patchwork formally, it is
> > > > out of sight for most of us and might miss proper review, except you are
> > > > sure you can always guarantee that. I don't want to start to argue about
> > > > all what happened in the past.
> > > > 
> > > > So, at least, if some patch arrived there mysteriously ;), the
> > > > linux-media list should be informed that it is there now and last time
> > > > to speak off, in case anything is not fully clear, before vanishing into
> > > > some black hole until you find it in the next kernel release ...
> > > 
> > > The only way to send patches to patchwork is to submit it via linux-media list.
> > > There's no other way. So, all patch discussions and reviews should happen at
> > > the ML, by replying at the patch email (or by replying another reply).
> > > Patchwork will keep track of such replies as well.
> > > 
> > 
> > What happened so far with this patches is quite funny,
> > for me some black hole seems to be involved.
> > 
> > Klaas did send them the first time, also directly to me, on Tue, 24 Mar
> > 2009 23:14:11 +0100.
> > 
> > Now I can see you have pulled them in already on Wednesday.
> > http://linuxtv.org/hg/v4l-dvb/rev/5efa9fbc8a88
> > 
> > There is no trace anymore on patchwork visible to me.
> > http://patchwork.kernel.org/project/linux-media/list
> > So I don't know how you processed them.
> 
> The above link uses the default patchwork filtering. By default it shows only
> patches where there's an action required (e. g. New or Under Review patches).
> 
> To view a full list of the patches, you need to click at filters and select any.
> 
> You'll see all patches:
> 	http://patchwork.kernel.org/project/linux-media/list/?state=*
> 
> In the specific case od Klaas, this is his patch:
> 
> http://patchwork.kernel.org/patch/14405/
> 
> > Most confusing is, that Klaas obviously did not receive a mail
> > notification from linuxtv-commits that his patch came in.
> 
> > 
> > Last message date: Fri Feb 15 19:45:02 CET 2008
> > Archived on: Fri Feb 15 19:45:04 CET 2008 
> > 
> > Is it broken or only the archive not up to date?
> > 
> 
> I've received the notification here:
> 
> From: Patch from klaas de waal  <hg-commit@linuxtv.org>
> To: linuxtv-commits@linuxtv.org
> Cc: , Mauro Carvalho Chehab <mchehab@redhat.com>, klaas de waal <klaas.de.waal@gmail.com>
> Subject: [linuxtv-commits] [hg:v4l-dvb] tda827x: fix locking issues with DVB-C
> Date: Fri, 27 Mar 2009 18:05:01 +0100
> Reply-To: klaas de waal via Mercurial <klaas.de.waal@gmail.com>
> Sender: linuxtv-commits-bounces@linuxtv.org
> 
> The patch number 11236 was added via Mauro Carvalho Chehab <mchehab@redhat.com>
> to http://linuxtv.org/hg/v4l-dvb master development tree.
> 
> Klaas should be received this also. Maybe some anti-spam filtering on his side?
> 
> You'll probably see this also at the linuxtv-commits archives.
> 
> > Why else he would have posted a second time on
> > Wed, 25 Mar 2009 21:53:02 +0100 not knowing anything about the status of
> > his patches, which made me believe I should try to help him?
> > 
> > The timestamp on your mercurial commit of them is
> > Wed Mar 25 20:53:02 2009 +0000 (2 days ago)
> > That is the time when his second email arrived converted to Greenwich
> > time? Or how could you commit within the same second that mail arrived?
> 
> > This is the time the patches have on both of his original mails.
> > --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
> > --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
> 
> The import scripts will try to preserve the original date of the sent email.
> 
> So, the date there is when the code were presented to public.
> 
> > How can I ever know when they were really added and if they went through
> > patchwork :)
> > 
> > I was just about to suggest Klaas should try again with [PATCH] in the
> > subject until they are listed at patchwork.
> 
> If the patch was received by patchwork, and "disappeared", all you need to do
> is to click on filter and select a proper filter, like:
> 
> http://patchwork.kernel.org/project/linux-media/list/?submitter=klaas&state=*
> 
> This will present all patches authored by "klaas", and their state. Ah, if you
> click on the patch, you'll see all the patch history, including the
> sent/received emails. Even this email should be added there by patchwork ;)
> 
> Cheers,
> Mauro

Mauro, you are joking.

How I ever could come to that from here?
http://patchwork.kernel.org/project/linux-media/list

I'm forced to read the source code.

There seems to be some serious utf8 bug too.

Cheers,
Hermann



--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
hermann pitton - March 28, 2009, 4:48 a.m.
Am Samstag, den 28.03.2009, 05:32 +0100 schrieb hermann pitton:
> Am Samstag, den 28.03.2009, 00:58 -0300 schrieb Mauro Carvalho Chehab:
> > On Sat, 28 Mar 2009 00:23:55 +0100
> > hermann pitton <hermann-pitton@arcor.de> wrote:
> > 
> > > Hi,
> > > 
> > > Am Freitag, den 27.03.2009, 07:38 -0300 schrieb Mauro Carvalho Chehab:
> > > > On Fri, 27 Mar 2009 02:39:07 +0100
> > > > hermann pitton <hermann-pitton@arcor.de> wrote:
> > > > 
> > > > > But my main concern is, if it once arrived at patchwork formally, it is
> > > > > out of sight for most of us and might miss proper review, except you are
> > > > > sure you can always guarantee that. I don't want to start to argue about
> > > > > all what happened in the past.
> > > > > 
> > > > > So, at least, if some patch arrived there mysteriously ;), the
> > > > > linux-media list should be informed that it is there now and last time
> > > > > to speak off, in case anything is not fully clear, before vanishing into
> > > > > some black hole until you find it in the next kernel release ...
> > > > 
> > > > The only way to send patches to patchwork is to submit it via linux-media list.
> > > > There's no other way. So, all patch discussions and reviews should happen at
> > > > the ML, by replying at the patch email (or by replying another reply).
> > > > Patchwork will keep track of such replies as well.
> > > > 
> > > 
> > > What happened so far with this patches is quite funny,
> > > for me some black hole seems to be involved.
> > > 
> > > Klaas did send them the first time, also directly to me, on Tue, 24 Mar
> > > 2009 23:14:11 +0100.
> > > 
> > > Now I can see you have pulled them in already on Wednesday.
> > > http://linuxtv.org/hg/v4l-dvb/rev/5efa9fbc8a88
> > > 
> > > There is no trace anymore on patchwork visible to me.
> > > http://patchwork.kernel.org/project/linux-media/list
> > > So I don't know how you processed them.
> > 
> > The above link uses the default patchwork filtering. By default it shows only
> > patches where there's an action required (e. g. New or Under Review patches).
> > 
> > To view a full list of the patches, you need to click at filters and select any.
> > 
> > You'll see all patches:
> > 	http://patchwork.kernel.org/project/linux-media/list/?state=*
> > 
> > In the specific case od Klaas, this is his patch:
> > 
> > http://patchwork.kernel.org/patch/14405/
> > 
> > > Most confusing is, that Klaas obviously did not receive a mail
> > > notification from linuxtv-commits that his patch came in.
> > 
> > > 
> > > Last message date: Fri Feb 15 19:45:02 CET 2008
> > > Archived on: Fri Feb 15 19:45:04 CET 2008 
> > > 
> > > Is it broken or only the archive not up to date?
> > > 
> > 
> > I've received the notification here:
> > 
> > From: Patch from klaas de waal  <hg-commit@linuxtv.org>
> > To: linuxtv-commits@linuxtv.org
> > Cc: , Mauro Carvalho Chehab <mchehab@redhat.com>, klaas de waal <klaas.de.waal@gmail.com>
> > Subject: [linuxtv-commits] [hg:v4l-dvb] tda827x: fix locking issues with DVB-C
> > Date: Fri, 27 Mar 2009 18:05:01 +0100
> > Reply-To: klaas de waal via Mercurial <klaas.de.waal@gmail.com>
> > Sender: linuxtv-commits-bounces@linuxtv.org
> > 
> > The patch number 11236 was added via Mauro Carvalho Chehab <mchehab@redhat.com>
> > to http://linuxtv.org/hg/v4l-dvb master development tree.
> > 
> > Klaas should be received this also. Maybe some anti-spam filtering on his side?
> > 
> > You'll probably see this also at the linuxtv-commits archives.
> > 
> > > Why else he would have posted a second time on
> > > Wed, 25 Mar 2009 21:53:02 +0100 not knowing anything about the status of
> > > his patches, which made me believe I should try to help him?
> > > 
> > > The timestamp on your mercurial commit of them is
> > > Wed Mar 25 20:53:02 2009 +0000 (2 days ago)
> > > That is the time when his second email arrived converted to Greenwich
> > > time? Or how could you commit within the same second that mail arrived?
> > 
> > > This is the time the patches have on both of his original mails.
> > > --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
> > > --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
> > 
> > The import scripts will try to preserve the original date of the sent email.
> > 
> > So, the date there is when the code were presented to public.
> > 
> > > How can I ever know when they were really added and if they went through
> > > patchwork :)
> > > 
> > > I was just about to suggest Klaas should try again with [PATCH] in the
> > > subject until they are listed at patchwork.
> > 
> > If the patch was received by patchwork, and "disappeared", all you need to do
> > is to click on filter and select a proper filter, like:
> > 
> > http://patchwork.kernel.org/project/linux-media/list/?submitter=klaas&state=*
> > 
> > This will present all patches authored by "klaas", and their state. Ah, if you
> > click on the patch, you'll see all the patch history, including the
> > sent/received emails. Even this email should be added there by patchwork ;)
> > 
> > Cheers,
> > Mauro
> 
> Mauro, you are joking.
> 
> How I ever could come to that from here?
> http://patchwork.kernel.org/project/linux-media/list
> 
> I'm forced to read the source code.
> 
> There seems to be some serious utf8 bug too.

Ok, I can see now you can click at least one of the 2mm buttons, of
course all self explaining :)

Cheers,
Hermann


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
hermann pitton - March 28, 2009, 5:51 a.m.
Am Samstag, den 28.03.2009, 05:48 +0100 schrieb hermann pitton:
> Am Samstag, den 28.03.2009, 05:32 +0100 schrieb hermann pitton:
> > Am Samstag, den 28.03.2009, 00:58 -0300 schrieb Mauro Carvalho Chehab:
> > > On Sat, 28 Mar 2009 00:23:55 +0100
> > > hermann pitton <hermann-pitton@arcor.de> wrote:
> > > 
> > > > Hi,
> > > > 
> > > > Am Freitag, den 27.03.2009, 07:38 -0300 schrieb Mauro Carvalho Chehab:
> > > > > On Fri, 27 Mar 2009 02:39:07 +0100
> > > > > hermann pitton <hermann-pitton@arcor.de> wrote:
> > > > > 
> > > > > > But my main concern is, if it once arrived at patchwork formally, it is
> > > > > > out of sight for most of us and might miss proper review, except you are
> > > > > > sure you can always guarantee that. I don't want to start to argue about
> > > > > > all what happened in the past.
> > > > > > 
> > > > > > So, at least, if some patch arrived there mysteriously ;), the
> > > > > > linux-media list should be informed that it is there now and last time
> > > > > > to speak off, in case anything is not fully clear, before vanishing into
> > > > > > some black hole until you find it in the next kernel release ...
> > > > > 
> > > > > The only way to send patches to patchwork is to submit it via linux-media list.
> > > > > There's no other way. So, all patch discussions and reviews should happen at
> > > > > the ML, by replying at the patch email (or by replying another reply).
> > > > > Patchwork will keep track of such replies as well.
> > > > > 
> > > > 
> > > > What happened so far with this patches is quite funny,
> > > > for me some black hole seems to be involved.
> > > > 
> > > > Klaas did send them the first time, also directly to me, on Tue, 24 Mar
> > > > 2009 23:14:11 +0100.
> > > > 
> > > > Now I can see you have pulled them in already on Wednesday.
> > > > http://linuxtv.org/hg/v4l-dvb/rev/5efa9fbc8a88
> > > > 
> > > > There is no trace anymore on patchwork visible to me.
> > > > http://patchwork.kernel.org/project/linux-media/list
> > > > So I don't know how you processed them.
> > > 
> > > The above link uses the default patchwork filtering. By default it shows only
> > > patches where there's an action required (e. g. New or Under Review patches).
> > > 
> > > To view a full list of the patches, you need to click at filters and select any.
> > > 
> > > You'll see all patches:
> > > 	http://patchwork.kernel.org/project/linux-media/list/?state=*
> > > 
> > > In the specific case od Klaas, this is his patch:
> > > 
> > > http://patchwork.kernel.org/patch/14405/
> > > 
> > > > Most confusing is, that Klaas obviously did not receive a mail
> > > > notification from linuxtv-commits that his patch came in.
> > > 
> > > > 
> > > > Last message date: Fri Feb 15 19:45:02 CET 2008
> > > > Archived on: Fri Feb 15 19:45:04 CET 2008 
> > > > 
> > > > Is it broken or only the archive not up to date?
> > > > 
> > > 
> > > I've received the notification here:
> > > 
> > > From: Patch from klaas de waal  <hg-commit@linuxtv.org>
> > > To: linuxtv-commits@linuxtv.org
> > > Cc: , Mauro Carvalho Chehab <mchehab@redhat.com>, klaas de waal <klaas.de.waal@gmail.com>
> > > Subject: [linuxtv-commits] [hg:v4l-dvb] tda827x: fix locking issues with DVB-C
> > > Date: Fri, 27 Mar 2009 18:05:01 +0100
> > > Reply-To: klaas de waal via Mercurial <klaas.de.waal@gmail.com>
> > > Sender: linuxtv-commits-bounces@linuxtv.org
> > > 
> > > The patch number 11236 was added via Mauro Carvalho Chehab <mchehab@redhat.com>
> > > to http://linuxtv.org/hg/v4l-dvb master development tree.
> > > 
> > > Klaas should be received this also. Maybe some anti-spam filtering on his side?
> > > 
> > > You'll probably see this also at the linuxtv-commits archives.
> > > 
> > > > Why else he would have posted a second time on
> > > > Wed, 25 Mar 2009 21:53:02 +0100 not knowing anything about the status of
> > > > his patches, which made me believe I should try to help him?
> > > > 
> > > > The timestamp on your mercurial commit of them is
> > > > Wed Mar 25 20:53:02 2009 +0000 (2 days ago)
> > > > That is the time when his second email arrived converted to Greenwich
> > > > time? Or how could you commit within the same second that mail arrived?
> > > 
> > > > This is the time the patches have on both of his original mails.
> > > > --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
> > > > --- a/linux/drivers/media/common/tuners/tda827x.c Tue Mar 24 21:12:47 2009 +0000
> > > 
> > > The import scripts will try to preserve the original date of the sent email.
> > > 
> > > So, the date there is when the code were presented to public.
> > > 
> > > > How can I ever know when they were really added and if they went through
> > > > patchwork :)
> > > > 
> > > > I was just about to suggest Klaas should try again with [PATCH] in the
> > > > subject until they are listed at patchwork.
> > > 
> > > If the patch was received by patchwork, and "disappeared", all you need to do
> > > is to click on filter and select a proper filter, like:
> > > 
> > > http://patchwork.kernel.org/project/linux-media/list/?submitter=klaas&state=*
> > > 
> > > This will present all patches authored by "klaas", and their state. Ah, if you
> > > click on the patch, you'll see all the patch history, including the
> > > sent/received emails. Even this email should be added there by patchwork ;)
> > > 
> > > Cheers,
> > > Mauro
> > 
> > Mauro, you are joking.
> > 
> > How I ever could come to that from here?
> > http://patchwork.kernel.org/project/linux-media/list
> > 
> > I'm forced to read the source code.
> > 
> > There seems to be some serious utf8 bug too.
> 
> Ok, I can see now you can click at least one of the 2mm buttons, of
> course all self explaining :)

One last comment on it, hopefully all goes well, but it did not go like
I would have preferred it.

It was not waited for, if somebody has eventually already the detailed
programming instructions for that one. It likely is the case after all
these years.

The patch was never tested by those eventually affected on the other
side, since at least I would have await that this direction is confirmed
to still be right previously :)

The driver maintainer, who has also high credits for moderating within
unrelated conflicting stuff he did not cause at all over years, did not
give a statement yet. My, wait at least a week after the patches are
around since ever anyway, except for getting the LNA config quiet.

Cheers,
Hermann






--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff -r e7d22285a9eb linux/drivers/media/common/tuners/tda827x.c
--- a/linux/drivers/media/common/tuners/tda827x.c	Sun Mar 22 22:42:26 2009 -0400
+++ b/linux/drivers/media/common/tuners/tda827x.c	Tue Mar 24 22:44:16 2009 +0100
@@ -352,7 +352,7 @@ 
 	u8  gc3;
 };
 
-static const struct tda827xa_data tda827xa_dvbt[] = {
+static struct tda827xa_data tda827xa_dvbt[] = {
 	{ .lomax =  56875000, .svco = 3, .spd = 4, .scr = 0, .sbs = 0, .gc3 = 1},
 	{ .lomax =  67250000, .svco = 0, .spd = 3, .scr = 0, .sbs = 0, .gc3 = 1},
 	{ .lomax =  81250000, .svco = 1, .spd = 3, .scr = 0, .sbs = 0, .gc3 = 1},
@@ -382,6 +382,36 @@ 
 	{ .lomax =         0, .svco = 0, .spd = 0, .scr = 0, .sbs = 0, .gc3 = 0}
 };
 
+static struct tda827xa_data tda827xa_dvbc[] = {
+	{ .lomax =  50125000, .svco = 2, .spd = 4, .scr = 2, .sbs = 0, .gc3 = 3},
+	{ .lomax =  58500000, .svco = 3, .spd = 4, .scr = 2, .sbs = 0, .gc3 = 3},
+	{ .lomax =  69250000, .svco = 0, .spd = 3, .scr = 2, .sbs = 0, .gc3 = 3},
+	{ .lomax =  83625000, .svco = 1, .spd = 3, .scr = 2, .sbs = 0, .gc3 = 3},
+	{ .lomax =  97500000, .svco = 2, .spd = 3, .scr = 2, .sbs = 0, .gc3 = 3},
+	{ .lomax = 100250000, .svco = 2, .spd = 3, .scr = 2, .sbs = 1, .gc3 = 1},
+	{ .lomax = 117000000, .svco = 3, .spd = 3, .scr = 2, .sbs = 1, .gc3 = 1},
+	{ .lomax = 138500000, .svco = 0, .spd = 2, .scr = 2, .sbs = 1, .gc3 = 1},
+	{ .lomax = 167250000, .svco = 1, .spd = 2, .scr = 2, .sbs = 1, .gc3 = 1},
+	{ .lomax = 187000000, .svco = 2, .spd = 2, .scr = 2, .sbs = 1, .gc3 = 1},
+	{ .lomax = 200500000, .svco = 2, .spd = 2, .scr = 2, .sbs = 2, .gc3 = 1},
+	{ .lomax = 234000000, .svco = 3, .spd = 2, .scr = 2, .sbs = 2, .gc3 = 3},
+	{ .lomax = 277000000, .svco = 0, .spd = 1, .scr = 2, .sbs = 2, .gc3 = 3},
+	{ .lomax = 325000000, .svco = 1, .spd = 1, .scr = 2, .sbs = 2, .gc3 = 1},
+	{ .lomax = 334500000, .svco = 1, .spd = 1, .scr = 2, .sbs = 3, .gc3 = 3},
+	{ .lomax = 401000000, .svco = 2, .spd = 1, .scr = 2, .sbs = 3, .gc3 = 3},
+	{ .lomax = 468000000, .svco = 3, .spd = 1, .scr = 2, .sbs = 3, .gc3 = 1},
+	{ .lomax = 535000000, .svco = 0, .spd = 0, .scr = 1, .sbs = 3, .gc3 = 1},
+	{ .lomax = 554000000, .svco = 0, .spd = 0, .scr = 2, .sbs = 3, .gc3 = 1},
+	{ .lomax = 638000000, .svco = 1, .spd = 0, .scr = 1, .sbs = 4, .gc3 = 1},
+	{ .lomax = 669000000, .svco = 1, .spd = 0, .scr = 2, .sbs = 4, .gc3 = 1},
+	{ .lomax = 720000000, .svco = 2, .spd = 0, .scr = 1, .sbs = 4, .gc3 = 1},
+	{ .lomax = 802000000, .svco = 2, .spd = 0, .scr = 2, .sbs = 4, .gc3 = 1},
+	{ .lomax = 835000000, .svco = 3, .spd = 0, .scr = 1, .sbs = 4, .gc3 = 1},
+	{ .lomax = 885000000, .svco = 3, .spd = 0, .scr = 1, .sbs = 4, .gc3 = 1},
+	{ .lomax = 911000000, .svco = 3, .spd = 0, .scr = 2, .sbs = 4, .gc3 = 1},
+	{ .lomax =         0, .svco = 0, .spd = 0, .scr = 0, .sbs = 0, .gc3 = 0}
+};
+
 static struct tda827xa_data tda827xa_analog[] = {
 	{ .lomax =  56875000, .svco = 3, .spd = 4, .scr = 0, .sbs = 0, .gc3 = 3},
 	{ .lomax =  67250000, .svco = 0, .spd = 3, .scr = 0, .sbs = 0, .gc3 = 3},
@@ -485,6 +515,7 @@ 
 			       struct dvb_frontend_parameters *params)
 {
 	struct tda827x_priv *priv = fe->tuner_priv;
+	struct tda827xa_data *frequency_map = tda827xa_dvbt;
 	u8 buf[11];
 
 	struct i2c_msg msg = { .addr = priv->i2c_addr, .flags = 0,
@@ -511,22 +542,27 @@ 
 	}
 	tuner_freq = params->frequency + if_freq;
 
+	if (fe->ops.info.type == FE_QAM) {
+		dprintk("%s select tda827xa_dvbc\n", __func__);
+		frequency_map = tda827xa_dvbc;
+	}
+
 	i = 0;
-	while (tda827xa_dvbt[i].lomax < tuner_freq) {
-		if(tda827xa_dvbt[i + 1].lomax == 0)
+	while (frequency_map[i].lomax < tuner_freq) {
+		if (frequency_map[i + 1].lomax == 0)
 			break;
 		i++;
 	}
 
-	N = ((tuner_freq + 31250) / 62500) << tda827xa_dvbt[i].spd;
+	N = ((tuner_freq + 31250) / 62500) << frequency_map[i].spd;
 	buf[0] = 0;            // subaddress
 	buf[1] = N >> 8;
 	buf[2] = N & 0xff;
 	buf[3] = 0;
 	buf[4] = 0x16;
-	buf[5] = (tda827xa_dvbt[i].spd << 5) + (tda827xa_dvbt[i].svco << 3) +
-			tda827xa_dvbt[i].sbs;
-	buf[6] = 0x4b + (tda827xa_dvbt[i].gc3 << 4);
+	buf[5] = (frequency_map[i].spd << 5) + (frequency_map[i].svco << 3) +
+			frequency_map[i].sbs;
+	buf[6] = 0x4b + (frequency_map[i].gc3 << 4);
 	buf[7] = 0x1c;
 	buf[8] = 0x06;
 	buf[9] = 0x24;
@@ -585,7 +621,7 @@ 
 
 	/* correct CP value */
 	buf[0] = 0x30;
-	buf[1] = 0x10 + tda827xa_dvbt[i].scr;
+	buf[1] = 0x10 + frequency_map[i].scr;
 	rc = tuner_transfer(fe, &msg, 1);
 	if (rc < 0)
 		goto err;
@@ -600,7 +636,7 @@ 
 	msleep(3);
 	/* freeze AGC1 */
 	buf[0] = 0x50;
-	buf[1] = 0x4f + (tda827xa_dvbt[i].gc3 << 4);
+	buf[1] = 0x4f + (frequency_map[i].gc3 << 4);
 	rc = tuner_transfer(fe, &msg, 1);
 	if (rc < 0)
 		goto err;
diff -r e7d22285a9eb linux/drivers/media/dvb/ttpci/budget-ci.c
--- a/linux/drivers/media/dvb/ttpci/budget-ci.c	Sun Mar 22 22:42:26 2009 -0400
+++ b/linux/drivers/media/dvb/ttpci/budget-ci.c	Tue Mar 24 22:44:16 2009 +0100
@@ -1084,6 +1084,10 @@ 
 	.deltaf = 0xa511,
 };
 
+static struct tda827x_config tda827x_config = {
+	.config = 0,
+};
+
 /* TT S2-3200 DVB-S (STB0899) Inittab */
 static const struct stb0899_s1_reg tt3200_stb0899_s1_init_1[] = {
 
@@ -1422,7 +1426,7 @@ 
 	case 0x101a: /* TT Budget-C-1501 (philips tda10023/philips tda8274A) */
 		budget_ci->budget.dvb_frontend = dvb_attach(tda10023_attach, &tda10023_config, &budget_ci->budget.i2c_adap, 0x48);
 		if (budget_ci->budget.dvb_frontend) {
-			if (dvb_attach(tda827x_attach, budget_ci->budget.dvb_frontend, 0x61, &budget_ci->budget.i2c_adap, NULL) == NULL) {
+			if (dvb_attach(tda827x_attach, budget_ci->budget.dvb_frontend, 0x61, &budget_ci->budget.i2c_adap, &tda827x_config) == NULL) {
 				printk(KERN_ERR "%s: No tda827x found!\n", __func__);
 				dvb_frontend_detach(budget_ci->budget.dvb_frontend);
 				budget_ci->budget.dvb_frontend = NULL;