Add AVerMedia A310 USB IDs to CE6230 driver.
diff mbox

Message ID b0bb99640903281936u43ba9a84l6cfa5c8d3d00de0e@mail.gmail.com
State Accepted
Headers show

Commit Message

Juan Jesús García de Soria Lucena March 29, 2009, 2:36 a.m. UTC
El día 28 de marzo de 2009 22:05, Mauro Carvalho Chehab
<mchehab@infradead.org> escribió:
> So, please send the patch you did for analysis. Please submit it as explained at [1].
>
> [1] http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches

Add AVerMedia A310 USB IDs to CE6230 driver.

From: Juan Jesús García de Soria Lucena <skandalfo@gmail.com>

The CE6230 DVB USB driver works correctly for the AVerMedia A310 USB2.0
DVB-T tuner. Add the required USB ID's and hardware names so that the
driver will handle it.

Priority: normal

Signed-off-by: Juan Jesús García de Soria Lucena <skandalfo@gmail.com>

diff -r b1596c6517c9 -r 71dd4cff4eb6
linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
--- a/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	Thu Mar 26
20:47:48 2009 +0000
+++ b/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	Sun Mar 29
04:27:54 2009 +0200
@@ -166,6 +166,7 @@
 #define USB_PID_AVERMEDIA_VOLAR_X			0xa815
 #define USB_PID_AVERMEDIA_VOLAR_X_2			0x8150
 #define USB_PID_AVERMEDIA_A309				0xa309
+#define USB_PID_AVERMEDIA_A310				0xa310
 #define USB_PID_TECHNOTREND_CONNECT_S2400               0x3006
 #define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY	0x005a
 #define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY_2	0x0081
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Antti Palosaari March 29, 2009, 10:40 a.m. UTC | #1
hello

Juan Jesús García de Soria Lucena wrote:
> El día 28 de marzo de 2009 22:05, Mauro Carvalho Chehab
> <mchehab@infradead.org> escribió:
>> So, please send the patch you did for analysis. Please submit it as explained at [1].
>>
>> [1] http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches
> 
> Add AVerMedia A310 USB IDs to CE6230 driver.
> 
> From: Juan Jesús García de Soria Lucena <skandalfo@gmail.com>
> 
> The CE6230 DVB USB driver works correctly for the AVerMedia A310 USB2.0
> DVB-T tuner. Add the required USB ID's and hardware names so that the
> driver will handle it.
> 
> Priority: normal
> 
> Signed-off-by: Juan Jesús García de Soria Lucena <skandalfo@gmail.com>
> 
> diff -r b1596c6517c9 -r 71dd4cff4eb6 linux/drivers/media/dvb/dvb-usb/ce6230.c

Thank you. Patch looks 100% correct and good for me.

Mauro, should I pick up and add this my devel tree and PULL-request or 
is there now patchwork which handles this? Current procedure is not 
clear for me...

regards
Antti
Mauro Carvalho Chehab March 29, 2009, 10:47 a.m. UTC | #2
On Sun, 29 Mar 2009 13:40:19 +0300
Antti Palosaari <crope@iki.fi> wrote:

> hello
> 
> Juan Jesús García de Soria Lucena wrote:
> > El día 28 de marzo de 2009 22:05, Mauro Carvalho Chehab
> > <mchehab@infradead.org> escribió:
> >> So, please send the patch you did for analysis. Please submit it as explained at [1].
> >>
> >> [1] http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches
> > 
> > Add AVerMedia A310 USB IDs to CE6230 driver.
> > 
> > From: Juan Jesús García de Soria Lucena <skandalfo@gmail.com>
> > 
> > The CE6230 DVB USB driver works correctly for the AVerMedia A310 USB2.0
> > DVB-T tuner. Add the required USB ID's and hardware names so that the
> > driver will handle it.
> > 
> > Priority: normal
> > 
> > Signed-off-by: Juan Jesús García de Soria Lucena <skandalfo@gmail.com>
> > 
> > diff -r b1596c6517c9 -r 71dd4cff4eb6 linux/drivers/media/dvb/dvb-usb/ce6230.c
> 
> Thank you. Patch looks 100% correct and good for me.
> 
> Mauro, should I pick up and add this my devel tree and PULL-request or 
> is there now patchwork which handles this? Current procedure is not 
> clear for me...

Any ways will work. 

In fact, it is easier to get from Patchwork since otherwise I'll need to
manually check what patches you got from the mailing list and manually update
its status at the Patchwork.

If you prefer me to pick it from patchwork, just reply with your acked-by:

Patchwork will automatically fold the acked together with the patch when I
download the patch to apply.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Antti Palosaari March 29, 2009, 10:51 a.m. UTC | #3
Juan Jesús García de Soria Lucena wrote:
> Add AVerMedia A310 USB IDs to CE6230 driver.
> 
> From: Juan Jesús García de Soria Lucena <skandalfo@gmail.com>
> 
> The CE6230 DVB USB driver works correctly for the AVerMedia A310 USB2.0
> DVB-T tuner. Add the required USB ID's and hardware names so that the
> driver will handle it.
> 
> Priority: normal
> 
> Signed-off-by: Juan Jesús García de Soria Lucena <skandalfo@gmail.com>

Acked-by: Antti Palosaari <crope@iki.fi>


regards
Antti

Patch
diff mbox

diff -r b1596c6517c9 -r 71dd4cff4eb6 linux/drivers/media/dvb/dvb-usb/ce6230.c
--- a/linux/drivers/media/dvb/dvb-usb/ce6230.c	Thu Mar 26 20:47:48 2009 +0000
+++ b/linux/drivers/media/dvb/dvb-usb/ce6230.c	Sun Mar 29 04:27:54 2009 +0200
@@ -253,6 +253,7 @@ 

 static struct usb_device_id ce6230_table[] = {
 	{ USB_DEVICE(USB_VID_INTEL, USB_PID_INTEL_CE9500) },
+	{ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A310) },
 	{ } /* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, ce6230_table);
@@ -287,12 +288,17 @@ 

 	.i2c_algo = &ce6230_i2c_algo,

-	.num_device_descs = 1,
+	.num_device_descs = 2,
 	.devices = {
 		{
 			.name = "Intel CE9500 reference design",
 			.cold_ids = {NULL},
 			.warm_ids = {&ce6230_table[0], NULL},
+		},
+		{
+			.name = "AVerMedia A310 USB 2.0 DVB-T tuner",
+			.cold_ids = {NULL},
+			.warm_ids = {&ce6230_table[1], NULL},
 		},
 	}
 };