diff mbox

headerdep: fix option processing for -I

Message ID 1238331707-23129-1-git-send-email-u.kleine-koenig@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Uwe Kleine-König March 29, 2009, 1:01 p.m. UTC 
-I takes an argument.  Without this change only a 1 is added to
@opt_include which is not helpful.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>

---
 scripts/headerdep.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Vegard Nossum March 29, 2009, 1:33 p.m. UTC | #1 
2009/3/29 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> -I takes an argument.  Without this change only a 1 is added to
> @opt_include which is not helpful.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Vegard Nossum <vegard.nossum@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
>
> ---
>  scripts/headerdep.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
> index 97399da..536408e 100755
> --- a/scripts/headerdep.pl
> +++ b/scripts/headerdep.pl
> @@ -19,7 +19,7 @@ my $opt_graph;
>        version => \&version,
>
>        all     => \$opt_all,
> -       I       => \@opt_include,
> +       "I:s"   => \@opt_include,
>        graph   => \$opt_graph,
>  );

Thanks!

Acked-by: Vegard Nossum <vegard.nossum@gmail.com>


Vegard
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Uwe Kleine-König March 29, 2009, 6:26 p.m. UTC | #2 
Hello,

sorry for replying to my own mail, but I found a further enhancement.

On Sun, Mar 29, 2009 at 03:01:47PM +0200, Uwe Kleine-König wrote:
> -I takes an argument.  Without this change only a 1 is added to
> @opt_include which is not helpful.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Vegard Nossum <vegard.nossum@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> 
> ---
>  scripts/headerdep.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
> index 97399da..536408e 100755
> --- a/scripts/headerdep.pl
> +++ b/scripts/headerdep.pl
> @@ -19,7 +19,7 @@ my $opt_graph;
>  	version	=> \&version,
>  
>  	all	=> \$opt_all,
> -	I	=> \@opt_include,
> +	"I:s"	=> \@opt_include,
This should better be "I=s".  The difference is that with : the argument
is optional, with = it is not.

Best regards
Uwe
diff mbox

Patch

diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
index 97399da..536408e 100755
--- a/scripts/headerdep.pl
+++ b/scripts/headerdep.pl
@@ -19,7 +19,7 @@  my $opt_graph;
 	version	=> \&version,
 
 	all	=> \$opt_all,
-	I	=> \@opt_include,
+	"I:s"	=> \@opt_include,
 	graph	=> \$opt_graph,
 );